Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2339653002: Revert of services/ui: Avoid thread hopping in the gpu process. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of services/ui: Avoid thread hopping in the gpu process. (patchset #3 id:40001 of https://codereview.chromium.org/2329043002/ ) Reason for revert: mus_ws_unittests on linux debug builders are crashing: [11191:11245:0913/111107:210172940:FATAL:lock_impl_posix.cc(65)] Check failed: rv == 0 (22 vs. 0). Invalid argument #0 0x7f806072969e base::debug::StackTrace::StackTrace() #1 0x7f806079332f logging::LogMessage::~LogMessage() #2 0x7f806089106d base::internal::LockImpl::Lock() #3 0x7f80606f9d23 base::Lock::Acquire() #4 0x7f80606f99c3 base::AutoLock::AutoLock() #5 0x7f8060857364 base::SequenceCheckerImpl::CalledOnValidSequence() #6 0x000000660eba base::Thread::task_runner() #7 0x0000006606b2 ui::GpuServiceInternal::Initialize() #8 0x0000006a14f0 ui::mojom::GpuServiceInternalStub::AcceptWithResponder() ... Original issue's description: > services/ui: Avoid thread hopping in the gpu process. > > Bind the GpuServiceInternal request on the gpu thread, instead of in the > main thread. This means it is possible to service a request from the host > without thread hopping between the main and gpu threads. > > BUG=643746 > > Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 > Cr-Commit-Position: refs/heads/master@{#418275} TBR=fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643746 Committed: https://crrev.com/d1cca1e62f682bb2c84a9272c603c4d3aa40047b Cr-Commit-Position: refs/heads/master@{#418344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -133 lines) Patch
M services/ui/gpu/gpu_service_internal.h View 3 chunks +23 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 5 chunks +164 lines, -131 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sadrul
Created Revert of services/ui: Avoid thread hopping in the gpu process.
4 years, 3 months ago (2016-09-13 19:49:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339653002/1
4 years, 3 months ago (2016-09-13 19:50:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 19:51:55 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 19:54:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1cca1e62f682bb2c84a9272c603c4d3aa40047b
Cr-Commit-Position: refs/heads/master@{#418344}

Powered by Google App Engine
This is Rietveld 408576698