Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2339213002: Add GrContextOptions flag to disable distance field path renderer. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GrContextOptions flag to disable distance field path renderer. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339213002 Committed: https://skia.googlesource.com/skia/+/6b2552f10983d1b6d33303e3e9965ae71944c1d5

Patch Set 1 #

Patch Set 2 : change default back #

Patch Set 3 : rm unneeded cons #

Patch Set 4 : Add trivial default constructor to satisfy clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M include/gpu/GrContextOptions.h View 1 2 3 1 chunk +20 lines, -29 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRendererChain.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
bsalomon
Turns out that Android so rarely scales paths that DF computation does more harm than ...
4 years, 3 months ago (2016-09-14 16:12:32 UTC) #3
jvanverth1
lgtm
4 years, 3 months ago (2016-09-14 20:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339213002/40001
4 years, 3 months ago (2016-09-14 20:23:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-arm64-Debug-GN_Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-arm64-Debug-GN_Android-Trybot/builds/335)
4 years, 3 months ago (2016-09-14 20:27:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339213002/60001
4 years, 3 months ago (2016-09-15 20:26:37 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:50:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6b2552f10983d1b6d33303e3e9965ae71944c1d5

Powered by Google App Engine
This is Rietveld 408576698