Add optional sw generated path coverage mask caching

Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008

All the bots except the painfully slow windows compiler have finished so,
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/39ef7fb885d7be648b9f0ecd027bc400d1213cec

[bsalomon, 2016-09-15 13:39:21]

Description was changed from

==========
start on GrSoftwarePathRenderer caching

BUG=skia:
==========

to

==========
start on GrSoftwarePathRenderer caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008
==========

[bsalomon, 2016-09-16 16:34:17]

bsalomon@google.com changed reviewers:
+ djsollen@google.com, herb@google.com

[bsalomon, 2016-09-16 16:34:18]

I want to improve testing of this before landing it, but I think it is ready to
try as far as testing Android perf.

[msarett, 2016-09-19 13:17:01]

msarett@google.com changed reviewers:
+ msarett@google.com

[bsalomon, 2016-09-19 16:39:21]

Description was changed from

==========
start on GrSoftwarePathRenderer caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008
==========

to

==========
Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008
==========

[bsalomon, 2016-09-19 16:39:21]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-21 13:55:55]

This is ready for review

[robertphillips, 2016-09-21 15:42:40]

first pass

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp
File gm/pathmaskcache.cpp (right):

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp#n...
gm/pathmaskcache.cpp:27: 
rm ?

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp#n...
gm/pathmaskcache.cpp:89: 
I'm a bit surprised we're not checking in to see what is actually getting
cached.

https://codereview.chromium.org/2335343008/diff/120001/include/gpu/GrContextO...
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/2335343008/diff/120001/include/gpu/GrContextO...
include/gpu/GrContextOptions.h:74: * If true this allows path mask textures to
be cached. This is only really useful if paths
with at -> at ?

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSWMaskHelper...
src/gpu/GrSWMaskHelper.h:10: 
Why <> style ?

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSoftwarePath...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSoftwarePath...
src/gpu/GrSoftwarePathRenderer.cpp:39: bool get_shape_and_clip_bounds(int width,
int height,
static here too ?

[bsalomon, 2016-09-21 16:01:10]

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp
File gm/pathmaskcache.cpp (right):

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp#n...
gm/pathmaskcache.cpp:27: 
On 2016/09/21 15:42:39, robertphillips wrote:
> rm ?

Done.

https://codereview.chromium.org/2335343008/diff/120001/gm/pathmaskcache.cpp#n...
gm/pathmaskcache.cpp:89: 
On 2016/09/21 15:42:39, robertphillips wrote:
> I'm a bit surprised we're not checking in to see what is actually getting
> cached.

I couldn't think of a good way to expose that here. We don't have equivalent
tests for DF masks, tessellated meshes, etc. It would be good to figure this
out.

https://codereview.chromium.org/2335343008/diff/120001/include/gpu/GrContextO...
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/2335343008/diff/120001/include/gpu/GrContextO...
include/gpu/GrContextOptions.h:74: * If true this allows path mask textures to
be cached. This is only really useful if paths
On 2016/09/21 15:42:39, robertphillips wrote:
> with at -> at ?

Done.

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSWMaskHelper...
src/gpu/GrSWMaskHelper.h:10: 
On 2016/09/21 15:42:39, robertphillips wrote:
> Why <> style ?

CLion auto inserter

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSoftwarePath...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2335343008/diff/120001/src/gpu/GrSoftwarePath...
src/gpu/GrSoftwarePathRenderer.cpp:39: bool get_shape_and_clip_bounds(int width,
int height,
On 2016/09/21 15:42:39, robertphillips wrote:
> static here too ?

Done.

[robertphillips, 2016-09-21 16:37:15]

lgtm

https://codereview.chromium.org/2335343008/diff/140001/include/gpu/GrContextO...
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/2335343008/diff/140001/include/gpu/GrContextO...
include/gpu/GrContextOptions.h:74: * If true this allows path mask textures to
be cached. This is only really useful if paths
space space after at ?

https://codereview.chromium.org/2335343008/diff/140001/src/gpu/GrSoftwarePath...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2335343008/diff/140001/src/gpu/GrSoftwarePath...
src/gpu/GrSoftwarePathRenderer.cpp:207: if (!texture) {
Is there something odd w/ the indent here ?

[bsalomon, 2016-09-21 17:34:05]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-21 17:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2335343008/#ps180001
(title: "Add .fs to literals in new gm")

[commit-bot: I haz the power, 2016-09-21 17:34:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-09-21 17:34:10]

https://codereview.chromium.org/2335343008/diff/140001/include/gpu/GrContextO...
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/2335343008/diff/140001/include/gpu/GrContextO...
include/gpu/GrContextOptions.h:74: * If true this allows path mask textures to
be cached. This is only really useful if paths
On 2016/09/21 16:37:15, robertphillips wrote:
> space space after at ?

Done.

https://codereview.chromium.org/2335343008/diff/140001/src/gpu/GrSoftwarePath...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2335343008/diff/140001/src/gpu/GrSoftwarePath...
src/gpu/GrSoftwarePathRenderer.cpp:207: if (!texture) {
On 2016/09/21 16:37:15, robertphillips wrote:
> Is there something odd w/ the indent here ?

Done.

[bsalomon, 2016-09-21 18:14:31]

Description was changed from

==========
Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008
==========

to

==========
Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008

All the bots except the painfully slow windows compiler have finished so,
NOTRY=true
==========

[bsalomon, 2016-09-21 18:14:39]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-09-21 18:14:44]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-09-21 18:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:16:07]

Description was changed from

==========
Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008

All the bots except the painfully slow windows compiler have finished so,
NOTRY=true
==========

to

==========
Add optional sw generated path coverage mask caching

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008

All the bots except the painfully slow windows compiler have finished so,
NOTRY=true

Committed:
https://skia.googlesource.com/skia/+/39ef7fb885d7be648b9f0ecd027bc400d1213cec
==========

[commit-bot: I haz the power, 2016-09-21 18:16:08]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/39ef7fb885d7be648b9f0ecd027bc400d1213cec