Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299
Committed: https://crrev.com/d3dd000ce7ea4854818f23ee10c68d0c86f95565
Cr-Commit-Position: refs/heads/master@{#420034}

[tzik, 2016-09-13 07:49:42]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 07:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-09-13 08:12:06]

Description was changed from

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

BUG=
==========

to

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299
==========

[tzik, 2016-09-13 08:12:06]

tzik@chromium.org changed reviewers:
+ stevenjb@chromium.org, tnagel@chromium.org

[tzik, 2016-09-13 08:12:27]

PTAL

[tzik, 2016-09-13 09:24:04]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 09:24:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 09:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:37:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-09-13 10:32:40]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 10:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 11:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 11:41:45]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-09-13 11:47:22]

tzik@chromium.org changed reviewers:
+ scheib@chromium.org

[tzik, 2016-09-13 11:47:23]

+scheib as a //device/bluetooth OWNER. PTAL.

[tzik, 2016-09-13 12:15:25]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 12:15:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 13:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:25:17]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-09-13 15:21:34]

c/b/chromeos lgtm

[scheib, 2016-09-13 20:03:37]

LGTM

[tzik, 2016-09-20 06:43:31]

tzik@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[tzik, 2016-09-20 06:44:45]

Adding pastarmovj@ as a policy/ OWNER. Could you take a look?

[pastarmovj, 2016-09-21 09:28:46]

lgtm

[tzik, 2016-09-21 10:10:57]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 13:26:38]

Description was changed from

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299
==========

to

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299
==========

[commit-bot: I haz the power, 2016-09-21 13:26:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-21 13:28:37]

Description was changed from

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299
==========

to

==========
Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued
pending tasks, which is less clean, and also that prevents a refactoring
that makes tasks move-only.

This CL replaces them with an equivalent HasPendingTask to avoid the copy.

BUG=554299

Committed: https://crrev.com/d3dd000ce7ea4854818f23ee10c68d0c86f95565
Cr-Commit-Position: refs/heads/master@{#420034}
==========

[commit-bot: I haz the power, 2016-09-21 13:28:38]

Patchset 5 (id:??) landed as
https://crrev.com/d3dd000ce7ea4854818f23ee10c68d0c86f95565
Cr-Commit-Position: refs/heads/master@{#420034}