Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: device/bluetooth/bluetooth_adapter_win_unittest.cc

Issue 2338733002: Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty() (Closed)
Patch Set: +bluetooth_adapter_win_unittest.cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/bluetooth/bluetooth_adapter_mac_unittest.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 EXPECT_TRUE(adapter_win_->IsInitialized()); 161 EXPECT_TRUE(adapter_win_->IsInitialized());
162 EXPECT_TRUE(init_callback_called_); 162 EXPECT_TRUE(init_callback_called_);
163 } 163 }
164 164
165 TEST_F(BluetoothAdapterWinTest, SingleStartDiscovery) { 165 TEST_F(BluetoothAdapterWinTest, SingleStartDiscovery) {
166 bluetooth_task_runner_->ClearPendingTasks(); 166 bluetooth_task_runner_->ClearPendingTasks();
167 CallAddDiscoverySession( 167 CallAddDiscoverySession(
168 base::Bind(&BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks, 168 base::Bind(&BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks,
169 base::Unretained(this)), 169 base::Unretained(this)),
170 DiscoverySessionErrorCallback()); 170 DiscoverySessionErrorCallback());
171 EXPECT_TRUE(ui_task_runner_->GetPendingTasks().empty()); 171 EXPECT_FALSE(ui_task_runner_->HasPendingTask());
172 EXPECT_EQ(1u, bluetooth_task_runner_->NumPendingTasks()); 172 EXPECT_EQ(1u, bluetooth_task_runner_->NumPendingTasks());
173 EXPECT_FALSE(adapter_->IsDiscovering()); 173 EXPECT_FALSE(adapter_->IsDiscovering());
174 EXPECT_EQ(0, num_start_discovery_callbacks_); 174 EXPECT_EQ(0, num_start_discovery_callbacks_);
175 adapter_win_->DiscoveryStarted(true); 175 adapter_win_->DiscoveryStarted(true);
176 ui_task_runner_->RunPendingTasks(); 176 ui_task_runner_->RunPendingTasks();
177 EXPECT_TRUE(adapter_->IsDiscovering()); 177 EXPECT_TRUE(adapter_->IsDiscovering());
178 EXPECT_EQ(1, num_start_discovery_callbacks_); 178 EXPECT_EQ(1, num_start_discovery_callbacks_);
179 EXPECT_EQ(1, observer_.discovering_changed_count()); 179 EXPECT_EQ(1, observer_.discovering_changed_count());
180 } 180 }
181 181
(...skipping 14 matching lines...) Expand all
196 bluetooth_task_runner_->ClearPendingTasks(); 196 bluetooth_task_runner_->ClearPendingTasks();
197 int num_discoveries = 5; 197 int num_discoveries = 5;
198 for (int i = 0; i < num_discoveries; i++) { 198 for (int i = 0; i < num_discoveries; i++) {
199 CallAddDiscoverySession( 199 CallAddDiscoverySession(
200 base::Bind( 200 base::Bind(
201 &BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks, 201 &BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks,
202 base::Unretained(this)), 202 base::Unretained(this)),
203 DiscoverySessionErrorCallback()); 203 DiscoverySessionErrorCallback());
204 EXPECT_EQ(1u, bluetooth_task_runner_->NumPendingTasks()); 204 EXPECT_EQ(1u, bluetooth_task_runner_->NumPendingTasks());
205 } 205 }
206 EXPECT_TRUE(ui_task_runner_->GetPendingTasks().empty()); 206 EXPECT_FALSE(ui_task_runner_->HasPendingTask());
207 EXPECT_FALSE(adapter_->IsDiscovering()); 207 EXPECT_FALSE(adapter_->IsDiscovering());
208 EXPECT_EQ(0, num_start_discovery_callbacks_); 208 EXPECT_EQ(0, num_start_discovery_callbacks_);
209 adapter_win_->DiscoveryStarted(true); 209 adapter_win_->DiscoveryStarted(true);
210 ui_task_runner_->RunPendingTasks(); 210 ui_task_runner_->RunPendingTasks();
211 EXPECT_TRUE(adapter_->IsDiscovering()); 211 EXPECT_TRUE(adapter_->IsDiscovering());
212 EXPECT_EQ(num_discoveries, num_start_discovery_callbacks_); 212 EXPECT_EQ(num_discoveries, num_start_discovery_callbacks_);
213 EXPECT_EQ(1, observer_.discovering_changed_count()); 213 EXPECT_EQ(1, observer_.discovering_changed_count());
214 } 214 }
215 215
216 TEST_F(BluetoothAdapterWinTest, MultipleStartDiscoveriesFailure) { 216 TEST_F(BluetoothAdapterWinTest, MultipleStartDiscoveriesFailure) {
(...skipping 25 matching lines...) Expand all
242 bluetooth_task_runner_->ClearPendingTasks(); 242 bluetooth_task_runner_->ClearPendingTasks();
243 for (int i = 0; i < 5; i++) { 243 for (int i = 0; i < 5; i++) {
244 int num_start_discovery_callbacks = num_start_discovery_callbacks_; 244 int num_start_discovery_callbacks = num_start_discovery_callbacks_;
245 CallAddDiscoverySession( 245 CallAddDiscoverySession(
246 base::Bind( 246 base::Bind(
247 &BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks, 247 &BluetoothAdapterWinTest::IncrementNumStartDiscoveryCallbacks,
248 base::Unretained(this)), 248 base::Unretained(this)),
249 DiscoverySessionErrorCallback()); 249 DiscoverySessionErrorCallback());
250 EXPECT_TRUE(adapter_->IsDiscovering()); 250 EXPECT_TRUE(adapter_->IsDiscovering());
251 EXPECT_TRUE(bluetooth_task_runner_->GetPendingTasks().empty()); 251 EXPECT_TRUE(bluetooth_task_runner_->GetPendingTasks().empty());
252 EXPECT_TRUE(ui_task_runner_->GetPendingTasks().empty()); 252 EXPECT_FALSE(ui_task_runner_->HasPendingTask());
253 EXPECT_EQ(num_start_discovery_callbacks + 1, 253 EXPECT_EQ(num_start_discovery_callbacks + 1,
254 num_start_discovery_callbacks_); 254 num_start_discovery_callbacks_);
255 } 255 }
256 EXPECT_EQ(1, observer_.discovering_changed_count()); 256 EXPECT_EQ(1, observer_.discovering_changed_count());
257 } 257 }
258 258
259 TEST_F(BluetoothAdapterWinTest, StartDiscoveryAfterDiscoveringFailure) { 259 TEST_F(BluetoothAdapterWinTest, StartDiscoveryAfterDiscoveringFailure) {
260 CallAddDiscoverySession( 260 CallAddDiscoverySession(
261 base::Closure(), 261 base::Closure(),
262 base::Bind( 262 base::Bind(
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 // Remove a service 502 // Remove a service
503 laptop_state->service_record_states.clear(); 503 laptop_state->service_record_states.clear();
504 observer_.Reset(); 504 observer_.Reset();
505 adapter_win_->DevicesPolled(devices); 505 adapter_win_->DevicesPolled(devices);
506 EXPECT_EQ(0, observer_.device_added_count()); 506 EXPECT_EQ(0, observer_.device_added_count());
507 EXPECT_EQ(0, observer_.device_removed_count()); 507 EXPECT_EQ(0, observer_.device_removed_count());
508 EXPECT_EQ(1, observer_.device_changed_count()); 508 EXPECT_EQ(1, observer_.device_changed_count());
509 } 509 }
510 510
511 } // namespace device 511 } // namespace device
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_adapter_mac_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698