chrome/browser/notifications/extension_welcome_notification_unittest.cc - Issue 2338733002: Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification_unittest.cc

Issue 2338733002: Use TestSimpleTaskRunner::HasPendingTask instead of GetPendingTasks().empty() (Closed)

Patch Set: +bluetooth_adapter_win_unittest.cc Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/system_log_uploader_unittest.cc ('k') | chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification_unittest.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification_unittest.cc b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

index 44a5c8bcf74f00713350d61100847bb87fb0e2e0..cae9ba2530091bd0a534899b3951eba551ae2b40 100644

--- a/chrome/browser/notifications/extension_welcome_notification_unittest.cc

+++ b/chrome/browser/notifications/extension_welcome_notification_unittest.cc

@@ -474,7 +474,7 @@ TEST_F(ExtensionWelcomeNotificationTest, TimeExpiredNotification) {

EXPECT_FALSE(GetBooleanPref(prefs::kWelcomeNotificationDismissedLocal));

EXPECT_FALSE(GetBooleanPref(prefs::kWelcomeNotificationPreviouslyPoppedUp));

EXPECT_EQ(GetInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp), 0);

- EXPECT_TRUE(task_runner()->GetPendingTasks().empty());

+ EXPECT_FALSE(task_runner()->HasPendingTask());

ShowChromeNowNotification();

@@ -498,7 +498,7 @@ TEST_F(ExtensionWelcomeNotificationTest, TimeExpiredNotification) {

SetElapsedTime(requested_show_time);

task_runner()->RunPendingTasks();

- EXPECT_TRUE(task_runner()->GetPendingTasks().empty());

+ EXPECT_FALSE(task_runner()->HasPendingTask());

EXPECT_EQ(message_center()->add_notification_calls(), 1);

EXPECT_EQ(message_center()->remove_notification_calls(), 1);

EXPECT_EQ(message_center()->notifications_with_shown_as_popup(), 0);

@@ -520,7 +520,7 @@ TEST_F(ExtensionWelcomeNotificationTest, NotificationPreviouslyExpired) {

EXPECT_FALSE(GetBooleanPref(prefs::kWelcomeNotificationDismissedLocal));

EXPECT_TRUE(GetBooleanPref(prefs::kWelcomeNotificationPreviouslyPoppedUp));

EXPECT_EQ(GetInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp), 1);

- EXPECT_TRUE(task_runner()->GetPendingTasks().empty());

+ EXPECT_FALSE(task_runner()->HasPendingTask());

const base::TimeDelta requested_show_time =

base::TimeDelta::FromDays(

@@ -528,7 +528,7 @@ TEST_F(ExtensionWelcomeNotificationTest, NotificationPreviouslyExpired) {

SetElapsedTime(requested_show_time);

ShowChromeNowNotification();

- EXPECT_TRUE(task_runner()->GetPendingTasks().empty());

+ EXPECT_FALSE(task_runner()->HasPendingTask());

EXPECT_EQ(message_center()->add_notification_calls(), 0);

EXPECT_EQ(message_center()->remove_notification_calls(), 0);

EXPECT_EQ(message_center()->notifications_with_shown_as_popup(), 0);