Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2338363002: Replace single-threaded SequencedWorkerPool with base::Thread in WallpaperResizerTest. (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 3 months ago
Reviewers:
msw, bshe
CC:
chromium-reviews, msw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace single-threaded SequencedWorkerPool with base::Thread in WallpaperResizerTest. Also while here: - const scoped_refptr<>& => scoped_refptr<> + std::move (helps avoiding unnecessary refcount bumps: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion) BUG=646443 Committed: https://crrev.com/2525299ceb48722a1271c8c7e8ae1bbd8aa724e3 Cr-Commit-Position: refs/heads/master@{#418855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M components/wallpaper/wallpaper_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/wallpaper/wallpaper_resizer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/wallpaper/wallpaper_resizer_unittest.cc View 5 chunks +11 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
gab
@bshe PTAL, thanks! CC msw FYI per new scoped_refptr style cleanup following https://codereview.chromium.org/2318223003
4 years, 3 months ago (2016-09-14 18:53:04 UTC) #4
msw
Thanks for cleaning up after my ignorance.
4 years, 3 months ago (2016-09-14 18:56:36 UTC) #6
bshe
On 2016/09/14 18:56:36, msw wrote: > Thanks for cleaning up after my ignorance. lgtm
4 years, 3 months ago (2016-09-15 13:23:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338363002/1
4 years, 3 months ago (2016-09-15 13:30:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 13:36:02 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 13:39:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2525299ceb48722a1271c8c7e8ae1bbd8aa724e3
Cr-Commit-Position: refs/heads/master@{#418855}

Powered by Google App Engine
This is Rietveld 408576698