Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/22327e7a3945aec88c8a1669b2da9aabefe13d88
Cr-Commit-Position: refs/heads/master@{#418912}

[gab, 2016-09-14 19:25:30]

Patchset #1 (id:1) has been deleted

[gab, 2016-09-14 19:26:26]

gab@chromium.org changed reviewers:
+ eroman@chromium.org

[gab, 2016-09-14 19:26:27]

Eric PTaL, thanks!

[eroman, 2016-09-14 19:54:02]

lgtm

https://codereview.chromium.org/2334163005/diff/20001/net/base/file_stream_un...
File net/base/file_stream_unittest.cc (right):

https://codereview.chromium.org/2334163005/diff/20001/net/base/file_stream_un...
net/base/file_stream_unittest.cc:746: // Force an operation through the pool.
Rename/clarify "pool" in this comment?

[gab, 2016-09-14 19:57:41]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:58:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:04:01]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gab, 2016-09-14 20:07:43]

Description was changed from

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
==========

to

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

[gab, 2016-09-14 20:08:48]

Thanks

https://codereview.chromium.org/2334163005/diff/20001/net/base/file_stream_un...
File net/base/file_stream_unittest.cc (right):

https://codereview.chromium.org/2334163005/diff/20001/net/base/file_stream_un...
net/base/file_stream_unittest.cc:746: // Force an operation through the pool.
On 2016/09/14 19:54:02, eroman wrote:
> Rename/clarify "pool" in this comment?

Done.

[gab, 2016-09-14 20:08:52]

The CQ bit was checked by gab@chromium.org

[gab, 2016-09-14 20:08:53]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2334163005/#ps40001
(title: "pool -> worker")

[commit-bot: I haz the power, 2016-09-14 20:09:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:13:29]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-09-14 20:24:48]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:29:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-09-15 17:52:40]

The CQ bit was checked by gab@chromium.org

[gab, 2016-09-15 17:52:40]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2334163005/#ps80001
(title: "rebase onto r418728")

[commit-bot: I haz the power, 2016-09-15 17:53:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:35:28]

Description was changed from

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

[commit-bot: I haz the power, 2016-09-15 18:35:29]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-15 18:39:10]

Description was changed from

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Replace single-threaded SequencedWorkerPool with base::Thread in net_unittests

Only logic change is that base::Thread will run all tasks before being
destroyed (as opposed to previous SKIP_ON_SHUTDOWN semantics), but no
tests called Shutdown() explicitly so I assume this wasn't an explicit
choice and that those tests don't care?

A few drive-by cleanups too.

BUG=646443
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/22327e7a3945aec88c8a1669b2da9aabefe13d88
Cr-Commit-Position: refs/heads/master@{#418912}
==========

[commit-bot: I haz the power, 2016-09-15 18:39:11]

Patchset 4 (id:??) landed as
https://crrev.com/22327e7a3945aec88c8a1669b2da9aabefe13d88
Cr-Commit-Position: refs/heads/master@{#418912}