mash: Migrate wallpaper controllers to ash/common.

mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org

Committed: https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab
Cr-Commit-Position: refs/heads/master@{#417420}

[msw, 2016-09-07 20:31:24]

Description was changed from

==========
mash: Migrate wallpaper controllers to WmShell and WmRootWindowController.

BUG=629605
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Add WmShell::GetBlockingPool (needed for WallpaperResizer)

Generalize WallpaperResizer to take a TaskRunner.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org
==========

[msw, 2016-09-07 20:31:25]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-09-07 20:32:21]

Hey James, please take a look; thanks!
(I'll add chrome/* and components/* owners later)

[msw, 2016-09-07 20:32:33]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 20:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:59:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[James Cook, 2016-09-07 21:27:05]

https://codereview.chromium.org/2318223003/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller_delegate_aura.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_controller_delegate_aura.cc:246: void
HandleToggleWallpaperMode() {
Can this accelerator be moved to
ash/common/accelerators/accelerator_controller.cc now that it doesn't use
ash::Shell?

https://codereview.chromium.org/2318223003/diff/20001/ash/aura/wm_root_window...
File ash/aura/wm_root_window_controller_aura.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/aura/wm_root_window...
ash/aura/wm_root_window_controller_aura.cc:112: }
optional: call the base class here?

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wallpaper/wa...
File ash/common/wallpaper/wallpaper_controller_unittest.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wallpaper/wa...
ash/common/wallpaper/wallpaper_controller_unittest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
Thanks for converting the tests too.

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:87: wallpaper_controller_.reset();
nit: destroy before accessibility_delegate unless it has to be this way (so they
unroll in the opposite order to creation)

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:360: virtual base::SequencedWorkerPool* GetBlockingPool()
= 0;
nit: forward declare base::SequencedWorkerPool (not sure where we're picking it
up)

https://codereview.chromium.org/2318223003/diff/20001/ash/default_wallpaper_d...
File ash/default_wallpaper_delegate.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/default_wallpaper_d...
ash/default_wallpaper_delegate.cc:31:
ash::WmShell::Get()->wallpaper_controller()->CreateEmptyWallpaper();
nit: no ash::

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:118: new base::SequencedWorkerPool(3,
Do you need to call blocking_pool_->Shutdown()?

Also, I'm not too familiar with SequencedWorkerPool. You might want to have
someone else look at this part. I seem to recall sky@ had an issue with shutdown
leaks doing something similar to this (even with Shutdown). See
https://codereview.chromium.org/2296973002

Also nit: It would be nice to comment what "3" is.

https://codereview.chromium.org/2318223003/diff/20001/components/wallpaper/wa...
File components/wallpaper/wallpaper_resizer.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/components/wallpaper/wa...
components/wallpaper/wallpaper_resizer.cc:122: scoped_refptr<base::TaskRunner>
task_runner_refptr(task_runner_);
I see you haven't changed this, but just for my knowledge... Is this a common
pattern with refptrs? It seems odd that we cache a raw pointer in |task_runner_|
then turn around later and make a refptr out of it to bump its refcount during
the task processing. It kinda seems like either the pointer should outline
WallpaperResizer, and hence shouldn't need refcounting, or it should be stored
in a refptr member variable.

[msw, 2016-09-07 22:25:15]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Add WmShell::GetBlockingPool (needed for WallpaperResizer)

Generalize WallpaperResizer to take a TaskRunner.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Add WmShell::GetBlockingPool (needed for WallpaperResizer)

Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

[msw, 2016-09-07 22:25:15]

msw@chromium.org changed reviewers:
+ achuith@chromium.org, sky@chromium.org

[msw, 2016-09-07 22:28:24]

James, thanks for great comments; please take another look.
Scott, please take a look at chrome/* and wm_shell_mus.*
Achuith (and FYI Biao), please review components/* [DEPS].
Thanks!

https://codereview.chromium.org/2318223003/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller_delegate_aura.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_controller_delegate_aura.cc:246: void
HandleToggleWallpaperMode() {
On 2016/09/07 21:27:05, James Cook wrote:
> Can this accelerator be moved to
> ash/common/accelerators/accelerator_controller.cc now that it doesn't use
> ash::Shell?

Done.

https://codereview.chromium.org/2318223003/diff/20001/ash/aura/wm_root_window...
File ash/aura/wm_root_window_controller_aura.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/aura/wm_root_window...
ash/aura/wm_root_window_controller_aura.cc:112: }
On 2016/09/07 21:27:05, James Cook wrote:
> optional: call the base class here?

Done.

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wallpaper/wa...
File ash/common/wallpaper/wallpaper_controller_unittest.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wallpaper/wa...
ash/common/wallpaper/wallpaper_controller_unittest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2016/09/07 21:27:05, James Cook wrote:
> Thanks for converting the tests too.

Acknowledged.

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:87: wallpaper_controller_.reset();
On 2016/09/07 21:27:05, James Cook wrote:
> nit: destroy before accessibility_delegate unless it has to be this way (so
they
> unroll in the opposite order to creation)

Done.

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:360: virtual base::SequencedWorkerPool* GetBlockingPool()
= 0;
On 2016/09/07 21:27:05, James Cook wrote:
> nit: forward declare base::SequencedWorkerPool (not sure where we're picking
it
> up)

Done.

https://codereview.chromium.org/2318223003/diff/20001/ash/default_wallpaper_d...
File ash/default_wallpaper_delegate.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/default_wallpaper_d...
ash/default_wallpaper_delegate.cc:31:
ash::WmShell::Get()->wallpaper_controller()->CreateEmptyWallpaper();
On 2016/09/07 21:27:05, James Cook wrote:
> nit: no ash::

Done.

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:118: new base::SequencedWorkerPool(3,
On 2016/09/07 21:27:05, James Cook wrote:
> Do you need to call blocking_pool_->Shutdown()?
> 
> Also, I'm not too familiar with SequencedWorkerPool. You might want to have
> someone else look at this part. I seem to recall sky@ had an issue with
shutdown
> leaks doing something similar to this (even with Shutdown). See
> https://codereview.chromium.org/2296973002
> 
> Also nit: It would be nice to comment what "3" is.
> 

Done; that fixes mash_unittests. I'll also ask Scott to check this.

https://codereview.chromium.org/2318223003/diff/20001/components/wallpaper/wa...
File components/wallpaper/wallpaper_resizer.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/components/wallpaper/wa...
components/wallpaper/wallpaper_resizer.cc:122: scoped_refptr<base::TaskRunner>
task_runner_refptr(task_runner_);
On 2016/09/07 21:27:05, James Cook wrote:
> I see you haven't changed this, but just for my knowledge... Is this a common
> pattern with refptrs? It seems odd that we cache a raw pointer in
|task_runner_|
> then turn around later and make a refptr out of it to bump its refcount during
> the task processing. It kinda seems like either the pointer should outline
> WallpaperResizer, and hence shouldn't need refcounting, or it should be stored
> in a refptr member variable.

I'm also not too familiar with this pattern or the reasoning behind it;
WallpaperResizer is very short lived and should outlive the task runner, so your
suggestion makes sense. I gave it a shot.

[msw, 2016-09-07 22:31:38]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-07 23:14:58]

LGTM but please make sure someone else double-checks the SequencedWorkerPool
bits.

https://codereview.chromium.org/2318223003/diff/60001/ash/common/accelerators...
File ash/common/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/2318223003/diff/60001/ash/common/accelerators...
ash/common/accelerators/accelerator_controller.cc:860: case
DEBUG_TOGGLE_WALLPAPER_MODE:
nit: Also remove DEBUG_TOGGLE_WALLPAPER_MODE from
https://cs.chromium.org/chromium/src/ash/mus/accelerators/accelerator_control...

[commit-bot: I haz the power, 2016-09-07 23:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:19:47]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-08 04:15:22]

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:118: new base::SequencedWorkerPool(3,
On 2016/09/07 22:28:24, msw wrote:
> On 2016/09/07 21:27:05, James Cook wrote:
> > Do you need to call blocking_pool_->Shutdown()?
> > 
> > Also, I'm not too familiar with SequencedWorkerPool. You might want to have
> > someone else look at this part. I seem to recall sky@ had an issue with
> shutdown
> > leaks doing something similar to this (even with Shutdown). See
> > https://codereview.chromium.org/2296973002
> > 
> > Also nit: It would be nice to comment what "3" is.
> > 
> 
> Done; that fixes mash_unittests. I'll also ask Scott to check this.

I believe you want to make it so you can inject a sequencedworkerpool for tests.
See base::SequencedWorkerPoolOwner for details on all the reasons you may run
into problems if you don't use SequencedWorkerPoolOwner in tests.

[msw, 2016-09-08 19:48:46]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Add WmShell::GetBlockingPool (needed for WallpaperResizer)

Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Move Shell::blocking_pool_ to WmShell; init for mash and tests.

Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

[msw, 2016-09-08 19:50:26]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)
Move Shell::blocking_pool_ to WmShell; init for mash and tests.

Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

[msw, 2016-09-08 19:52:15]

Hey Scott, please take another look; thanks!

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2318223003/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:118: new base::SequencedWorkerPool(3,
On 2016/09/08 04:15:22, sky wrote:
> On 2016/09/07 22:28:24, msw wrote:
> > On 2016/09/07 21:27:05, James Cook wrote:
> > > Do you need to call blocking_pool_->Shutdown()?
> > > 
> > > Also, I'm not too familiar with SequencedWorkerPool. You might want to
have
> > > someone else look at this part. I seem to recall sky@ had an issue with
> > shutdown
> > > leaks doing something similar to this (even with Shutdown). See
> > > https://codereview.chromium.org/2296973002
> > > 
> > > Also nit: It would be nice to comment what "3" is.
> > > 
> > 
> > Done; that fixes mash_unittests. I'll also ask Scott to check this.
> 
> I believe you want to make it so you can inject a sequencedworkerpool for
tests.
> See base::SequencedWorkerPoolOwner for details on all the reasons you may run
> into problems if you don't use SequencedWorkerPoolOwner in tests.

Done; I moved Shell::blocking_pool_ to WmShell, made WindowManagerApplication
create/own the pool for mash (except in tests, afaict), and made WmTestHelper
own a SequencedWorkerPoolOwner for tests. This required some
WindowManager[Application] initialization plumbing. Please let me know if you
see a better approach.

https://codereview.chromium.org/2318223003/diff/60001/ash/common/accelerators...
File ash/common/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/2318223003/diff/60001/ash/common/accelerators...
ash/common/accelerators/accelerator_controller.cc:860: case
DEBUG_TOGGLE_WALLPAPER_MODE:
On 2016/09/07 23:14:57, James Cook wrote:
> nit: Also remove DEBUG_TOGGLE_WALLPAPER_MODE from
>
https://cs.chromium.org/chromium/src/ash/mus/accelerators/accelerator_control...
> 

Done.

[msw, 2016-09-08 19:52:23]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:58:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-09-08 20:03:11]

I only looked at the blocking pool wiring, LGTM

[msw, 2016-09-08 20:21:50]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org,achuith@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org
==========

[msw, 2016-09-08 20:21:50]

msw@chromium.org changed reviewers:
+ bshe@chromium.org

[msw, 2016-09-08 20:21:59]

The CQ bit was checked by msw@chromium.org

[msw, 2016-09-08 20:22:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2318223003/#ps120001
(title: "Add base/test:test_support dep to ash/mus:unittests.")

[commit-bot: I haz the power, 2016-09-08 20:22:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:24:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[James Cook, 2016-09-08 20:27:55]

still lgtm with a nit for the future

https://codereview.chromium.org/2318223003/diff/120001/ash/mus/test/wm_test_h...
File ash/mus/test/wm_test_helper.h (right):

https://codereview.chromium.org/2318223003/diff/120001/ash/mus/test/wm_test_h...
ash/mus/test/wm_test_helper.h:12: #include
"base/test/sequenced_worker_pool_owner.h"
nit: maybe for a followup CL, can this be forward declared?

[msw, 2016-09-08 20:41:41]

https://codereview.chromium.org/2318223003/diff/120001/ash/mus/test/wm_test_h...
File ash/mus/test/wm_test_helper.h (right):

https://codereview.chromium.org/2318223003/diff/120001/ash/mus/test/wm_test_h...
ash/mus/test/wm_test_helper.h:12: #include
"base/test/sequenced_worker_pool_owner.h"
On 2016/09/08 20:27:55, James Cook wrote:
> nit: maybe for a followup CL, can this be forward declared?

Done.

[msw, 2016-09-08 20:41:47]

The CQ bit was checked by msw@chromium.org

[msw, 2016-09-08 20:41:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2318223003/#ps140001
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-09-08 20:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:35:48]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org
==========

[commit-bot: I haz the power, 2016-09-08 22:35:49]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-08 22:40:43]

Description was changed from

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org
==========

to

==========
mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org

Committed: https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab
Cr-Commit-Position: refs/heads/master@{#417420}
==========

[commit-bot: I haz the power, 2016-09-08 22:40:44]

Patchset 8 (id:??) landed as
https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab
Cr-Commit-Position: refs/heads/master@{#417420}