Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2338333002: Make DefaultComponentInstallerTest's SequencedWorkerPool multi-threaded. (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DefaultComponentInstallerTest's SequencedWorkerPool multi-threaded. BUG=646443 NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/ee46aaa20cac1fa414809d49c762bc284863020d Cr-Commit-Position: refs/heads/master@{#419070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/component_updater/default_component_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (16 generated)
gab
@waffles PTAL, thanks!
4 years, 3 months ago (2016-09-14 18:05:13 UTC) #3
waffles
lgtm
4 years, 3 months ago (2016-09-15 18:10:36 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2333023003 Patch 100001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-15 18:44:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338333002/1
4 years, 3 months ago (2016-09-15 18:49:29 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260380)
4 years, 3 months ago (2016-09-15 18:59:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338333002/1
4 years, 3 months ago (2016-09-15 21:17:55 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260543)
4 years, 3 months ago (2016-09-15 21:27:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338333002/1
4 years, 3 months ago (2016-09-16 00:38:04 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 01:25:25 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 01:28:47 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee46aaa20cac1fa414809d49c762bc284863020d
Cr-Commit-Position: refs/heads/master@{#419070}

Powered by Google App Engine
This is Rietveld 408576698