Remove explicit usage of SequencedWorkerPool from UploadList.

Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
    https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion)

BUG=646443
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/9954e8c35b3a0228c6bf10f712921514da491478
Cr-Commit-Position: refs/heads/master@{#418981}

[gab, 2016-09-14 18:18:13]

Description was changed from

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

BUG=646443
==========

to

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
==========

[gab, 2016-09-14 18:18:58]

gab@chromium.org changed reviewers:
+ mark@chromium.org

[gab, 2016-09-14 18:18:59]

Mark PTaL, thanks!

[gab, 2016-09-15 18:00:25]

On 2016/09/14 18:18:59, gab wrote:
> Mark PTaL, thanks!

ping mark@, thanks!

[Mark Mentovai, 2016-09-15 18:07:33]

LGTM, Thanks!

[gab, 2016-09-15 18:48:50]

Description was changed from

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
==========

to

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

[gab, 2016-09-15 18:49:01]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:52:51]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-09-15 20:43:30]

The CQ bit was checked by gab@chromium.org

[gab, 2016-09-15 20:43:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2335193007/#ps20001
(title: "rebase on r417159")

[commit-bot: I haz the power, 2016-09-15 20:43:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:29:03]

Description was changed from

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

[commit-bot: I haz the power, 2016-09-15 21:29:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 21:31:38]

Description was changed from

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Remove explicit usage of SequencedWorkerPool from UploadList.

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
   
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/dis...)

BUG=646443
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/9954e8c35b3a0228c6bf10f712921514da491478
Cr-Commit-Position: refs/heads/master@{#418981}
==========

[commit-bot: I haz the power, 2016-09-15 21:31:39]

Patchset 2 (id:??) landed as
https://crrev.com/9954e8c35b3a0228c6bf10f712921514da491478
Cr-Commit-Position: refs/heads/master@{#418981}