Replace usage of single-threaded SequencedWorkerPool with a base::Thread in image_fetcher_unittest.…

Replace usage of single-threaded SequencedWorkerPool with a base::Thread in image_fetcher_unittest.mm

Also cleaned up a TODO for 440857 on the way.

BUG=646443, 440857
Committed: https://crrev.com/cab88d00953b328b6ee4e4aa285a686da79cfb57
Cr-Commit-Position: refs/heads/master@{#419049}

[gab, 2016-09-13 18:05:37]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:21:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[gab, 2016-09-13 19:35:11]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-13 19:45:30]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:45:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-13 19:54:15]

Patchset #4 (id:60001) has been deleted

[gab, 2016-09-13 20:31:29]

Patchset #1 (id:1) has been deleted

[gab, 2016-09-13 20:32:04]

Patchset #1 (id:20001) has been deleted

[gab, 2016-09-13 20:32:41]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 20:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-13 20:48:44]

gab@chromium.org changed reviewers:
+ droger@chromium.org

[gab, 2016-09-13 20:48:44]

@droger PTaL, thanks!

[gab, 2016-09-13 20:48:54]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-09-13 21:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:57:32]

Dry run: This issue passed the CQ dry run.

[droger, 2016-09-14 08:43:09]

Not giving the LG because of the memory leak issue. Other than that it looks
good.

https://codereview.chromium.org/2333023003/diff/80001/ios/chrome/browser/net/...
File ios/chrome/browser/net/image_fetcher_unittest.mm (right):

https://codereview.chromium.org/2333023003/diff/80001/ios/chrome/browser/net/...
ios/chrome/browser/net/image_fetcher_unittest.mm:106: ImageFetchedCallback
callback_;
I don't think this change is right, can you revert it?

ImageFetchedCallback is a Objective-C block, not a base::Callback.
The call to "copy" on line 80 above has to be balanced by a release, which is
what ScopedBlock does.

[gab, 2016-09-14 14:00:32]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:00:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-14 14:01:45]

Thanks, PTanL

https://codereview.chromium.org/2333023003/diff/80001/ios/chrome/browser/net/...
File ios/chrome/browser/net/image_fetcher_unittest.mm (right):

https://codereview.chromium.org/2333023003/diff/80001/ios/chrome/browser/net/...
ios/chrome/browser/net/image_fetcher_unittest.mm:106: ImageFetchedCallback
callback_;
On 2016/09/14 08:43:09, droger wrote:
> I don't think this change is right, can you revert it?
> 
> ImageFetchedCallback is a Objective-C block, not a base::Callback.
> The call to "copy" on line 80 above has to be balanced by a release, which is
> what ScopedBlock does.

Oops, my bad, thought this was yet another use case of unnecessary usage of a
heap ptr for a member.

Done.

[droger, 2016-09-14 14:38:55]

lgtm

[commit-bot: I haz the power, 2016-09-14 15:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:32:33]

Dry run: This issue passed the CQ dry run.

[gab, 2016-09-15 22:32:04]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:32:41]

This CL has an open dependency (Issue 2337253003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[gab, 2016-09-15 23:14:10]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:14:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 00:20:55]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-09-16 00:22:44]

Description was changed from

==========
Replace usage of single-threaded SequencedWorkerPool with a base::Thread in
image_fetcher_unittest.mm

Also cleaned up a TODO for 440857 on the way.

BUG=646443, 440857
==========

to

==========
Replace usage of single-threaded SequencedWorkerPool with a base::Thread in
image_fetcher_unittest.mm

Also cleaned up a TODO for 440857 on the way.

BUG=646443, 440857

Committed: https://crrev.com/cab88d00953b328b6ee4e4aa285a686da79cfb57
Cr-Commit-Position: refs/heads/master@{#419049}
==========

[commit-bot: I haz the power, 2016-09-16 00:22:45]

Patchset 2 (id:??) landed as
https://crrev.com/cab88d00953b328b6ee4e4aa285a686da79cfb57
Cr-Commit-Position: refs/heads/master@{#419049}