Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2338153004: FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint (Closed)

Created:
4 years, 3 months ago by Kunihiko Sakamoto
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint This will help us better understand the potential for improving the abandonment rate of the FirstMeaningfulPaint UMA. BUG=632081 Committed: https://crrev.com/232674743920e446fb92ac8f9e124cdc9c035ed2 Cr-Commit-Position: refs/heads/master@{#419651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Kunihiko Sakamoto
4 years, 3 months ago (2016-09-14 07:01:38 UTC) #6
Steven Holte
lgtm
4 years, 3 months ago (2016-09-15 19:18:50 UTC) #9
Kunihiko Sakamoto
Hi Bryan, could you take a look at this and the other one (https://crrev.com/2345443002)? Thanks!
4 years, 3 months ago (2016-09-16 01:48:42 UTC) #10
Bryan McQuade
lgtm
4 years, 3 months ago (2016-09-19 17:31:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338153004/1
4 years, 3 months ago (2016-09-20 00:27:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 02:14:53 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:17:22 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/232674743920e446fb92ac8f9e124cdc9c035ed2
Cr-Commit-Position: refs/heads/master@{#419651}

Powered by Google App Engine
This is Rietveld 408576698