chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc - Issue 2338153004: FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2338153004: FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

index a559ced11d2d3dd6f5c6f562d996d9630a2f59aa..8fd4c709ff1ca29ea1c012a8052e41df50886b8e 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

@@ -601,7 +601,9 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(

if (timing.first_paint && !timing.first_meaningful_paint) {

RecordFirstMeaningfulPaintStatus(

- internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE);

+ timing.first_contentful_paint ?

+ internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE :

+ internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_FIRST_CONTENTFUL_PAINT);

}