chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h - Issue 2338153004: FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2338153004: FirstMeaningfulPaint UMA: Add a new bucket for page loads aborted before FirstContentfulPaint (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

index 468fce22c7c182607990ba5fac535e0878bf1f32..024b4a29ad663577e491af9ddf21552151c5ce62 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

@@ -55,6 +55,7 @@ enum FirstMeaningfulPaintStatus {

FIRST_MEANINGFUL_PAINT_BACKGROUNDED,

FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE,

FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP,

+ FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_FIRST_CONTENTFUL_PAINT,

FIRST_MEANINGFUL_PAINT_LAST_ENTRY

};

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | no next file with comments »