chrome/browser/resources/settings/search_engines_page/search_engines_list.html - Issue 2338133011: MD Settings: Use scrollable behavior for all iron-list containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

Issue 2338133011: MD Settings: Use scrollable behavior for all iron-list containers (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/on_startup_page/startup_urls_page.html ('K') | « chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_list.js » ('j') | chrome/browser/resources/settings/search_engines_page/search_engines_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

index 20a9316762f18aa0709e3cf36f59b9a5930f6fbd..a1c3ea5462a06311c415931b860cc671b792a8eb 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

@@ -1,6 +1,7 @@

+<link rel="import" href="chrome://resources/cr_elements/cr_scrollable_behavior.html">

+<link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">

-<link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">

<dom-module id="settings-search-engines-list">

@@ -34,13 +35,15 @@

</style>

- <iron-list items="[[engines]]" selectable>

- <template>

- <settings-search-engine-entry engine="[[item]]"

- tabindex$="[[tabIndex]]">

- </settings-search-engine-entry>

- </template>

- </iron-list>

+ <div id="container" class="scroll-container" scrollable>

dpapad 2016/09/17 00:05:53 Is the id necessary? I don't see it used here, or

stevenjb 2016/09/26 21:58:19 Next line: 'scroll-target="container"'

+ <iron-list items="[[engines]]" scroll-target="container">

+ <template>

+ <settings-search-engine-entry engine="[[item]]"

+ tabindex$="[[tabIndex]]">

+ </settings-search-engine-entry>

+ </template>

+ </iron-list>

+ </div>

</div>

</template>