Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.js

Issue 2338133011: MD Settings: Use scrollable behavior for all iron-list containers (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.js b/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
index 391444486e1141af676e25bc86117cd0f7872237..d196acaa7856bdb7d0720f01ed1743f7dd00e7fd 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
@@ -9,6 +9,8 @@
Polymer({
is: 'settings-search-engines-list',
+ behaviors: [CrScrollableBehavior],
+
properties: {
/** @type {!Array<!SearchEngine>} */
engines: {
@@ -20,8 +22,6 @@ Polymer({
/** @private */
enginesChanged_: function() {
- // Rather than adding an event to notify this element when it is shown,
- // observe changes to |engines| and notify the iron-list.
- this.$$('iron-list').fire('iron-resize');
+ this.updateScrollableContents();
dpapad 2016/09/17 00:05:53 I am not familiar with CrScrollableBehavior. By re
stevenjb 2016/09/19 16:19:15 We switched to iron-list primarily for its keyboar
},
});

Powered by Google App Engine
This is Rietveld 408576698