chrome/browser/resources/settings/on_startup_page/startup_urls_page.html - Issue 2338133011: MD Settings: Use scrollable behavior for all iron-list containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

Issue 2338133011: MD Settings: Use scrollable behavior for all iron-list containers (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp » ('j') | chrome/browser/resources/settings/search_engines_page/search_engines_list.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

index 462c8a839cdaa2e0a3ea5bca93ec8f2a6f79658c..a00e970f7c0c3b14af693b93778589fd025ca649 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

@@ -19,7 +19,7 @@

}

</style>

- <div id="container" class="layout vertical flex" scrollable>

dpapad 2016/09/17 00:05:53 This change should probably be on a different CL,

stevenjb 2016/09/26 21:58:19 The change is related so I will update the CL desc

+ <div id="container" class="scroll-container flex" scrollable>

<iron-list items="[[startupPages_]]" scroll-target="container">

<settings-startup-url-entry model="[[item]]"