Adapt to changes in html5 spec related to tfoot

Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
Committed: https://crrev.com/f7e6a1c1af9daed5c77c4fc7da3b5eeafe95bf86
Cr-Commit-Position: refs/heads/master@{#419468}

[rwlbuis, 2016-09-14 20:57:08]

Description was changed from

==========
641338 WIP

BUG=
==========

to

==========
641338 WIP

BUG=641338
==========

[rwlbuis, 2016-09-14 20:57:49]

Description was changed from

==========
641338 WIP

BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

BUG=641338
==========

[rwlbuis, 2016-09-14 21:02:23]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new element
should be inserted at the end.
This patch also changes behavior so we throw a
HierarchyRequestError when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

[rwlbuis, 2016-09-14 21:02:37]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new element
should be inserted at the end.
This patch also changes behavior so we throw a
HierarchyRequestError when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

[rwlbuis, 2016-09-14 21:02:50]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

[rwlbuis, 2016-09-14 21:03:02]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot
BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot


BUG=641338
==========

[rwlbuis, 2016-09-14 21:03:10]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot


BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

[rwlbuis, 2016-09-14 21:03:53]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-09-14 21:03:54]

PTAL.

[tkent, 2016-09-14 22:55:41]

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1258: crbug.com/641338
tables/mozilla/bugs/bug30418.html [ NeedsRebaseline ]
Why does it need rebaseline?
Can you add new baseline png for one platform to this CL?

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
(left):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html:12: //
TODO(foolip): Setting caption/tHead/tFoot to null should not throw
The comment is still valid for caption and tHead.

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
(right):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html:18:
shouldNotThrow("t.tFoot = null");
We should confirm that t.tFoot is removed from |t| by t.tFoot=null with non-null
t.tFoot.

[rwlbuis, 2016-09-15 14:32:33]

I think I addressed the review comments.

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1258: crbug.com/641338
tables/mozilla/bugs/bug30418.html [ NeedsRebaseline ]
On 2016/09/14 22:55:41, tkent wrote:
> Why does it need rebaseline?
> Can you add new baseline png for one platform to this CL?

Unfortunately there are three platforms AFAICS with different png results for
this test (win/mac/lin).

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
(left):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html:12: //
TODO(foolip): Setting caption/tHead/tFoot to null should not throw
On 2016/09/14 22:55:41, tkent wrote:
> The comment is still valid for caption and tHead.

Done.

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
(right):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html:18:
shouldNotThrow("t.tFoot = null");
On 2016/09/14 22:55:41, tkent wrote:
> We should confirm that t.tFoot is removed from |t| by t.tFoot=null with
non-null
> t.tFoot.

Done.

[tkent, 2016-09-15 23:32:56]

What about behavior of Firefox and Edge?

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1258: crbug.com/641338
tables/mozilla/bugs/bug30418.html [ NeedsRebaseline ]
On 2016/09/15 at 14:32:33, rwlbuis wrote:
> On 2016/09/14 22:55:41, tkent wrote:
> > Why does it need rebaseline?
> > Can you add new baseline png for one platform to this CL?
> 
> Unfortunately there are three platforms AFAICS with different png results for
this test (win/mac/lin).

I didn't ask to add results of all platforms.  Adding a png for *one* platform
to a CL and keeping [NeedsRebaseline] would be very helpful to review.

I still have the question. Why does the test need rebaseline?

[rwlbuis, 2016-09-16 14:56:38]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

[rwlbuis, 2016-09-16 15:20:12]

On 2016/09/15 23:32:56, tkent wrote:
> What about behavior of Firefox and Edge?

Firefox passes. Edge fails the second to last test because of an Exception
difference but basically passes.

>
https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2338013007/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:1258: crbug.com/641338
> tables/mozilla/bugs/bug30418.html [ NeedsRebaseline ]
> On 2016/09/15 at 14:32:33, rwlbuis wrote:
> > On 2016/09/14 22:55:41, tkent wrote:
> > > Why does it need rebaseline?
> > > Can you add new baseline png for one platform to this CL?
> > 
> > Unfortunately there are three platforms AFAICS with different png results
for
> this test (win/mac/lin).
> 
> I didn't ask to add results of all platforms.  Adding a png for *one* platform
> to a CL and keeping [NeedsRebaseline] would be very helpful to review.

Ah I misinformed you. I thought the png results changed but in fact they did
not, see below.

> I still have the question. Why does the test need rebaseline?

Sorrty about missing that, so for png no change, but txt results are different
because the render tree layout dump shows the tfoot render info now as last
child instead of point of insertion.

[tkent, 2016-09-18 21:32:01]

lgtm

[rwlbuis, 2016-09-18 22:09:05]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-09-18 22:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 22:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 22:11:18]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rwlbuis, 2016-09-19 14:11:18]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-09-19 14:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2338013007/#ps80001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-09-19 14:11:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 15:50:39]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

[commit-bot: I haz the power, 2016-09-19 15:50:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-19 15:52:47]

Description was changed from

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338
==========

to

==========
Adapt to changes in html5 spec related to tfoot

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338

Committed: https://crrev.com/f7e6a1c1af9daed5c77c4fc7da3b5eeafe95bf86
Cr-Commit-Position: refs/heads/master@{#419468}
==========

[commit-bot: I haz the power, 2016-09-19 15:52:49]

Patchset 5 (id:??) landed as
https://crrev.com/f7e6a1c1af9daed5c77c4fc7da3b5eeafe95bf86
Cr-Commit-Position: refs/heads/master@{#419468}