third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html - Issue 2338013007: Adapt to changes in html5 spec related to tfoot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

Issue 2338013007: Adapt to changes in html5 spec related to tfoot (Closed)

Patch Set: Patch for landing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

index 38a24130ef91f5536802bfabb2129e965b6f04e8..f88742b990faf6cb0999ed88292c963346939d05 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

@@ -9,15 +9,18 @@

var t = document.createElement('table');

- // TODO(foolip): Setting caption/tHead/tFoot to null should not throw

- // an exception, it should just remove the old caption/thead/tfoot.

+ // TODO(foolip): Setting caption/tHead to null should not throw

+ // an exception, it should just remove the old caption/thead.

shouldThrow("t.caption = null");

shouldThrow("t.caption = document.body");

shouldThrow("t.tHead = null");

shouldThrow("t.tHead = document.body");

- shouldThrow("t.tFoot = null");

+ shouldBe("t.createTFoot()", "t.tFoot");

+ shouldBeNonNull("t.tFoot");

+ shouldNotThrow("t.tFoot = null");

+ shouldBeNull("t.tFoot");

shouldThrow("t.tFoot = document.body");

shouldThrow("t.insertRow(-2)");