third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html - Issue 2338013007: Adapt to changes in html5 spec related to tfoot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

Issue 2338013007: Adapt to changes in html5 spec related to tfoot (Closed)

Patch Set: Fix tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("This test should trigger exceptions on HTMLTableElement, an d verify that the messages are reasonably helpful.");	8 description("This test should trigger exceptions on HTMLTableElement, an d verify that the messages are reasonably helpful.");

9	9

10 var t = document.createElement('table');	10 var t = document.createElement('table');

11	11

12 // TODO(foolip): Setting caption/tHead/tFoot to null should not throw
tkent 2016/09/14 22:55:41 The comment is still valid for caption and tHead. The comment is still valid for caption and tHead. rwlbuis 2016/09/15 14:32:33 Done. Show quoted text On 2016/09/14 22:55:41, tkent wrote: > The comment is still valid for caption and tHead. Done.
13 // an exception, it should just remove the old caption/thead/tfoot.

14 shouldThrow("t.caption = null");	12 shouldThrow("t.caption = null");

15 shouldThrow("t.caption = document.body");	13 shouldThrow("t.caption = document.body");

16	14

17 shouldThrow("t.tHead = null");	15 shouldThrow("t.tHead = null");

18 shouldThrow("t.tHead = document.body");	16 shouldThrow("t.tHead = document.body");

19	17

20 shouldThrow("t.tFoot = null");	18 shouldNotThrow("t.tFoot = null");
	tkent 2016/09/14 22:55:41 We should confirm that t.tFoot is removed from \|t\| We should confirm that t.tFoot is removed from \|t\| by t.tFoot=null with non-null t.tFoot. rwlbuis 2016/09/15 14:32:33 Done. Show quoted text On 2016/09/14 22:55:41, tkent wrote: > We should confirm that t.tFoot is removed from \|t\| by t.tFoot=null with non-null > t.tFoot. Done.
21 shouldThrow("t.tFoot = document.body");	19 shouldThrow("t.tFoot = document.body");

22	20

23 shouldThrow("t.insertRow(-2)");	21 shouldThrow("t.insertRow(-2)");

24 shouldThrow("t.insertRow(1)");	22 shouldThrow("t.insertRow(1)");

25	23

26 t.insertRow();	24 t.insertRow();

27	25

28 shouldThrow("t.deleteRow(-2)");	26 shouldThrow("t.deleteRow(-2)");

29 shouldThrow("t.deleteRow(2)");	27 shouldThrow("t.deleteRow(2)");

30 shouldThrow("t.deleteRow()");	28 shouldThrow("t.deleteRow()");

31 </script>	29 </script>

32 </body>	30 </body>

33 </html>	31 </html>

OLD	NEW