Fork cc::OutputSurface into cc::CompositorFrameSink.

cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1120f4c4ee426227a3cea04f3b086d5fa6ec4daf
Cr-Commit-Position: refs/heads/master@{#418754}

[danakj, 2016-09-13 23:22:23]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
==========

to

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[danakj, 2016-09-13 23:22:24]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-13 23:24:10]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-09-13 23:24:28]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-13 23:24:28]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-13 23:24:28]

danakj@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[danakj, 2016-09-13 23:24:28]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-13 23:24:29]

danakj@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[danakj, 2016-09-13 23:24:29]

danakj@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-13 23:29:35]

Description was changed from

==========
Fork cc::OutputSurface into cc::CompositorFrameSink.

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-13 23:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:29:40]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-09-13 23:29:55]

Description was changed from

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

R=boliu, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-13 23:29:55]

danakj@chromium.org changed reviewers:
+ fsamuel@chromium.org

[danakj, 2016-09-13 23:31:06]

danakj@chromium.org changed reviewers:
+ sky@chromium.org
- fsamuel@chromium.org

[danakj, 2016-09-13 23:55:27]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:55:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-14 00:01:55]

danakj@chromium.org changed reviewers:
+ sievers@chromium.org

[danakj, 2016-09-14 00:01:57]

Long patch is long.

enne: overall and cc/, content/renderer/gpu/, WebKit
boliu: content/renderer/android/, content/browser/android/
sky: services/, ui/views/
Khushal: blimp/
sievers: the rest of content/

[danakj, 2016-09-14 00:02:40]

danakj@chromium.org changed reviewers:
+ dcheng@chromium.org

[danakj, 2016-09-14 00:02:41]

+dcheng for renaming an IPC in content/common/android/sync_compositor_messages.h

[commit-bot: I haz the power, 2016-09-14 00:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:12:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2016-09-14 00:16:20]

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
File cc/output/compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
cc/output/compositor_frame_sink.h:70: flipped_COMPOSITOR_FRAME_SINK(false),
drive-by: unintended caps here?

[danakj, 2016-09-14 00:18:46]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[boliu, 2016-09-14 00:19:33]

my parts lgtm

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
File content/common/android/sync_compositor_messages.h (right):

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
content/common/android/sync_compositor_messages.h:133: uint32_t /*
output_surface_id */,
one more..

actually if you chase this one down, there is another whole web of renames
required, because this value passes through a bunch of classes, so not sure if
you want to do that in a separate CL or not :p

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
content/common/android/sync_compositor_messages.h:158: uint32_t /*
output_surface_id */,
one more..

[commit-bot: I haz the power, 2016-09-14 00:19:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-09-14 00:35:46]

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink.h:57: // to
short comment is short

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor_frame_sink_proxy.h (right):

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_proxy.h:48: // No
<_<

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc
(left):

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc:58: bound_
= true;
That's a thing.  Is this variable even used?

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc
(right):

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc:125: //
main
More paragraph formattin'

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc:159: // the
main
Here three

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc:211: // the
Here four

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
File cc/output/compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
cc/output/compositor_frame_sink.h:152: // should
Here eleventy

https://codereview.chromium.org/2337913003/diff/20001/cc/resources/resource_p...
File cc/resources/resource_provider_unittest.cc (left):

https://codereview.chromium.org/2337913003/diff/20001/cc/resources/resource_p...
cc/resources/resource_provider_unittest.cc:3540: FakeOutputSurfaceClient
output_surface_client;
Removing output surface for all these resource provider tests is great.

https://codereview.chromium.org/2337913003/diff/20001/cc/surfaces/direct_comp...
File cc/surfaces/direct_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/surfaces/direct_comp...
cc/surfaces/direct_compositor_frame_sink.cc:126: // This is a delegating output
surface, no framebuffer/direct drawing support.
I guess this function will go away soon, but here's an "output surface"
referenced in a comment.  Both here and below.

https://codereview.chromium.org/2337913003/diff/20001/cc/surfaces/direct_comp...
File cc/surfaces/direct_compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/surfaces/direct_comp...
cc/surfaces/direct_compositor_frame_sink.h:28: // The underlying Display and
SurfaceManager must outlive this class.
(and allocator?)

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.cc:549: // Note: It is safe to drop all output surface
references here as
output surface in comments

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_client.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_client.h:50: // should
Comment formatting part #infinity

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1463: // and
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:2289: // pointer
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:2296: // rasterization.
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:2343: // means a
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_interface.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_interface.h:82: // using
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_interface.h:94: // CompositorFrameSink,
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:2747: // TestCompositorFrameSink
overridCompositorFrameSink.
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_context.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_context.cc:161: //
CreateDisplayCompositorFrameSink
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_context.cc:499: // (which is
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/proxy_impl.cc
File cc/trees/proxy_impl.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/proxy_impl.cc#...
cc/trees/proxy_impl.cc:102: // try
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/remote_channel...
File cc/trees/remote_channel_impl.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/remote_channel...
cc/trees/remote_channel_impl.cc:58: // processing
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/remote_channel...
cc/trees/remote_channel_impl.cc:413: // queued
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/remote_channel...
cc/trees/remote_channel_impl.cc:424: // will
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/single_thread_...
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/single_thread_...
cc/trees/single_thread_proxy.cc:157: // RequestNewCompositorFrameSink,
@_@

https://codereview.chromium.org/2337913003/diff/20001/cc/trees/single_thread_...
cc/trees/single_thread_proxy.cc:300: // try
@_@

https://codereview.chromium.org/2337913003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/2337913003/diff/20001/content/browser/rendere...
content/browser/renderer_host/compositor_impl_android.cc:646: // the
@_@

https://codereview.chromium.org/2337913003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/compositor_impl_android.h (right):

https://codereview.chromium.org/2337913003/diff/20001/content/browser/rendere...
content/browser/renderer_host/compositor_impl_android.h:176: // |host_|. Becomes
|true| if RequestNewOutputSurface is called, and |false|
RequestNewCompositorFrameSink?

https://codereview.chromium.org/2337913003/diff/20001/content/browser/rendere...
content/browser/renderer_host/compositor_impl_android.h:178: // OutputSurface
(which is essentially the contract with cc).
CompositorFrameSink?

[commit-bot: I haz the power, 2016-09-14 00:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:38:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-09-14 01:06:03]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 01:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-14 01:09:11]

Done all the comments thanks for helping my exhausted self find them all.

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc
(left):

https://codereview.chromium.org/2337913003/diff/20001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc:58: bound_
= true;
On 2016/09/14 00:35:44, enne wrote:
> That's a thing.  Is this variable even used?

I think that tests check it became true, but nothing checks unbinding.

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
File cc/output/compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/20001/cc/output/compositor_fr...
cc/output/compositor_frame_sink.h:70: flipped_COMPOSITOR_FRAME_SINK(false),
On 2016/09/14 00:16:19, jbroman wrote:
> drive-by: unintended caps here?

yep thx

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
File content/common/android/sync_compositor_messages.h (right):

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
content/common/android/sync_compositor_messages.h:133: uint32_t /*
output_surface_id */,
On 2016/09/14 00:19:33, boliu wrote:
> one more..
> 
> actually if you chase this one down, there is another whole web of renames
> required, because this value passes through a bunch of classes, so not sure if
> you want to do that in a separate CL or not :p

Done. Ohh. ya there's a lot. Maybe separate CL.

https://codereview.chromium.org/2337913003/diff/20001/content/common/android/...
content/common/android/sync_compositor_messages.h:158: uint32_t /*
output_surface_id */,
On 2016/09/14 00:19:33, boliu wrote:
> one more..

Done.

[danakj, 2016-09-14 01:39:43]

ok I renamed all |output_surface_id|s as well.

dcheng: additional comment-only renamings happened in view_messages.

[dcheng, 2016-09-14 01:49:20]

rs lgtm for ipc

[danakj, 2016-09-14 02:07:06]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 02:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 02:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 02:31:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-09-14 02:45:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 02:46:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-14 02:49:55]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 02:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-14 03:01:54]

LGTM

https://codereview.chromium.org/2337913003/diff/120001/services/ui/public/cpp...
File services/ui/public/cpp/compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/120001/services/ui/public/cpp...
services/ui/public/cpp/compositor_frame_sink.h:22: class CompositorFrameSink :
public cc::CompositorFrameSink,
Please outside of cc have no idea what classes like this do. It would be nice to
add some documentation to help those poor souls (such as myself).

[Khushal, 2016-09-14 03:10:35]

lgtm

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
File blimp/client/core/compositor/blimp_compositor.cc (right):

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
blimp/client/core/compositor/blimp_compositor.cc:311: // async
Pretty comment is not pretty. :(

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
File blimp/client/core/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
blimp/client/core/compositor/blimp_compositor.h:153: // CompositorFrameSink
The comment looks off?

[David Trainor- moved to gerrit, 2016-09-14 03:49:23]

dtrainor@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2016-09-14 03:49:25]

blimp/ owners lgtm

[commit-bot: I haz the power, 2016-09-14 04:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 04:33:04]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-14 17:17:09]

danakj@chromium.org changed reviewers:
+ piman@chromium.org

[danakj, 2016-09-14 17:17:15]

+piman for content/ outside content/*/android/

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
File blimp/client/core/compositor/blimp_compositor.cc (right):

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
blimp/client/core/compositor/blimp_compositor.cc:311: // async
On 2016/09/14 03:10:35, Khushal wrote:
> Pretty comment is not pretty. :(

Done.

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
File blimp/client/core/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/2337913003/diff/120001/blimp/client/core/comp...
blimp/client/core/compositor/blimp_compositor.h:153: // CompositorFrameSink
On 2016/09/14 03:10:35, Khushal wrote:
> The comment looks off?

Done.

https://codereview.chromium.org/2337913003/diff/120001/services/ui/public/cpp...
File services/ui/public/cpp/compositor_frame_sink.h (right):

https://codereview.chromium.org/2337913003/diff/120001/services/ui/public/cpp...
services/ui/public/cpp/compositor_frame_sink.h:22: class CompositorFrameSink :
public cc::CompositorFrameSink,
On 2016/09/14 03:01:54, sky wrote:
> Please outside of cc have no idea what classes like this do. It would be nice
to
> add some documentation to help those poor souls (such as myself).

Thx for the feedback. I'll write some comments on the new CompositorFrameSink
class as I clean it up (right now it's mostly noise).

[danakj, 2016-09-14 17:20:14]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:20:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-09-14 17:59:40]

lgtm

[commit-bot: I haz the power, 2016-09-14 19:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:40:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-09-14 19:45:46]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:46:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:58:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danakj, 2016-09-14 20:01:31]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:16:55]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danakj, 2016-09-14 23:06:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 23:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-14 23:10:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 23:10:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-15 00:23:23]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-09-15 00:24:24]

I went thru the remaining pieces in content/ and there's really nothing
interesting in there except renames so I'll TBR @ piman for those cuz I'm scared
of rebasing this thing more.

[danakj, 2016-09-15 00:24:43]

Description was changed from

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-15 00:24:54]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-09-15 00:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
dcheng@chromium.org, dtrainor@chromium.org, sky@chromium.org,
khushalsagar@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2337913003/#ps200001
(title: "cfsfork: android-vulkan")

[commit-bot: I haz the power, 2016-09-15 00:25:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-09-15 00:57:33]

lgtm

[commit-bot: I haz the power, 2016-09-15 02:05:51]

Description was changed from

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-15 02:05:54]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-09-15 02:07:39]

Description was changed from

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fork OutputSurface into CompositorFrameSink.

After this, OutputSurface is only used for the display
compositor (ie cc::Display and friends). And the
CompositorFrameSink API is used for the layer tree
compositor (ie LayerTreeHost and friends).

OutputSurfaceClient is also forked to an identical
CompositorFrameSinkClient.

For now the two are identical, after this they can diverge
and we can delete things on each that doesn't apply anymore.

Broad renamings are:
SynchronousCompositorOutputSurface -> SynchronousCompositorFrameSink
blimp::DelegatedOutputSurface -> BlimpCompositorFrameSink
BlimpOutputSurfaceClient -> BlimpCompositorFrameSinkProxy
BlimpOutputSurface -> BlimpCompositorFrameSinkProxyClient
SurfaceDisplayOutputSurface -> DirectCompositorFrameSink
TestDelegatingOutputSurface -> TestCompositorFrameSink
CompositorOutputSurface -> RendererCompositorFrameSink
mus::OutputSurface -> mus::CompositorFrameSink

TBR=piman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1120f4c4ee426227a3cea04f3b086d5fa6ec4daf
Cr-Commit-Position: refs/heads/master@{#418754}
==========

[commit-bot: I haz the power, 2016-09-15 02:07:43]

Patchset 11 (id:??) landed as
https://crrev.com/1120f4c4ee426227a3cea04f3b086d5fa6ec4daf
Cr-Commit-Position: refs/heads/master@{#418754}