Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2337763003: [regexp] Fix incorrect range checks in AtSurrogatePair (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix incorrect range checks in AtSurrogatePair R=littledan@chromium.org BUG=v8:5339 Committed: https://crrev.com/6b3cd5804dc9ed3d467f5fb8104698aecf9d9d65 Cr-Commit-Position: refs/heads/master@{#39403}

Patch Set 1 #

Patch Set 2 : Add testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regexp.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (14 generated)
jgruber
4 years, 3 months ago (2016-09-13 10:58:50 UTC) #5
Yang
lgtm. nice catch. maybe test case?
4 years, 3 months ago (2016-09-13 11:57:37 UTC) #7
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-09-13 17:10:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337763003/20001
4 years, 3 months ago (2016-09-14 07:52:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 07:55:10 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:55:41 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b3cd5804dc9ed3d467f5fb8104698aecf9d9d65
Cr-Commit-Position: refs/heads/master@{#39403}

Powered by Google App Engine
This is Rietveld 408576698