Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2330413002: [regexp] Remove dead code from regexp.js (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg, adamk, Yang
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove dead code from regexp.js R=littledan@chromium.org BUG=v8:5339 Committed: https://crrev.com/eeb52516362250e6d1fa827e4ab37278f5595df7 Cr-Commit-Position: refs/heads/master@{#39401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -85 lines) Patch
M src/js/regexp.js View 4 chunks +0 lines, -85 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
jgruber
4 years, 3 months ago (2016-09-13 10:58:17 UTC) #5
Yang
lgtm :)
4 years, 3 months ago (2016-09-13 11:55:31 UTC) #7
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-09-13 17:50:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330413002/1
4 years, 3 months ago (2016-09-14 07:16:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 07:37:51 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:38:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeb52516362250e6d1fa827e4ab37278f5595df7
Cr-Commit-Position: refs/heads/master@{#39401}

Powered by Google App Engine
This is Rietveld 408576698