src/js/regexp.js - Issue 2337763003: [regexp] Fix incorrect range checks in AtSurrogatePair

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/regexp.js

Issue 2337763003: [regexp] Fix incorrect range checks in AtSurrogatePair (Closed)

Patch Set: Add testcase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/regexp.js

diff --git a/src/js/regexp.js b/src/js/regexp.js

index 8e27059bcc861047b1b2d377fb2a29c3e3473f59..b9b096492b754095d41056f72e82411e49376e13 100644

--- a/src/js/regexp.js

+++ b/src/js/regexp.js

@@ -296,7 +296,7 @@ function AtSurrogatePair(subject, index) {

var first = %_StringCharCodeAt(subject, index);

if (first < 0xD800 || first > 0xDBFF) return false;

var second = %_StringCharCodeAt(subject, index + 1);

- return second >= 0xDC00 || second <= 0xDFFF;

+ return second >= 0xDC00 && second <= 0xDFFF;

}

« no previous file with comments | « no previous file | test/mjsunit/regexp.js » ('j') | no next file with comments »