Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2338273004: Process data in task-page-data (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@stub-task2
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Apply aliases to dimensions #

Total comments: 2

Patch Set 4 : Define now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/taskpage/task-page-data.html View 1 2 3 4 chunks +67 lines, -5 lines 0 comments Download
M appengine/swarming/elements/res/js/alias.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2337363003 Patch 80001

Dependent Patchsets:

Issue 2337363004 Patch 80001
Issue 2337363004 Patch 100001
Issue 2337363004 Patch 120001
Issue 2337363004 Patch 140001
Issue 2337363004 Patch 160001

Messages

Total messages: 11 (4 generated)
kjlubick
4 years, 3 months ago (2016-09-14 20:20:05 UTC) #2
jcgregorio
https://codereview.chromium.org/2338273004/diff/40001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html File appengine/swarming/elements/res/imp/taskpage/task-page-data.html (right): https://codereview.chromium.org/2338273004/diff/40001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html#newcode185 appengine/swarming/elements/res/imp/taskpage/task-page-data.html:185: result.duration = (now - result.started_ts) / 1000; Where did ...
4 years, 3 months ago (2016-09-20 13:02:16 UTC) #3
kjlubick
https://codereview.chromium.org/2338273004/diff/40001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html File appengine/swarming/elements/res/imp/taskpage/task-page-data.html (right): https://codereview.chromium.org/2338273004/diff/40001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html#newcode185 appengine/swarming/elements/res/imp/taskpage/task-page-data.html:185: result.duration = (now - result.started_ts) / 1000; On 2016/09/20 ...
4 years, 3 months ago (2016-09-20 13:48:13 UTC) #4
jcgregorio
lgtm
4 years, 3 months ago (2016-09-20 13:53:06 UTC) #5
KevinL
lgtm
4 years, 3 months ago (2016-09-20 14:00:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338273004/60001
4 years, 3 months ago (2016-09-20 14:00:14 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 14:03:48 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/cd54a32317ddda8ca002fea5c0cedf5b79205fa0

Powered by Google App Engine
This is Rietveld 408576698