Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy (Closed)
Patch Set: fix comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index 8f17765e4d18fa2bba7266e1cd5a6a8c15bd63a4..b9aaee042b4d1be2b77f05b3a5d2c8778f2dec4e 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -264,11 +264,11 @@ void ServiceWorkerGlobalScopeProxy::didLoadWorkerScript(size_t scriptSize, size_
m_workerGlobalScope->didLoadWorkerScript(scriptSize, cachedMetadataSize);
}
-void ServiceWorkerGlobalScopeProxy::didEvaluateWorkerScript(bool success)
+void ServiceWorkerGlobalScopeProxy::didCreateWorkerGlobalScope(WorkerOrWorkletGlobalScope* workerGlobalScope)
{
- DCHECK(m_workerGlobalScope);
- m_workerGlobalScope->didEvaluateWorkerScript();
- client().didEvaluateWorkerScript(success);
+ DCHECK(!m_workerGlobalScope);
+ m_workerGlobalScope = static_cast<ServiceWorkerGlobalScope*>(workerGlobalScope);
+ client().workerContextStarted(this);
}
void ServiceWorkerGlobalScopeProxy::didInitializeWorkerContext()
@@ -277,14 +277,14 @@ void ServiceWorkerGlobalScopeProxy::didInitializeWorkerContext()
client().didInitializeWorkerContext(workerGlobalScope()->scriptController()->context());
}
-void ServiceWorkerGlobalScopeProxy::workerGlobalScopeStarted(WorkerOrWorkletGlobalScope* workerGlobalScope)
+void ServiceWorkerGlobalScopeProxy::didEvaluateWorkerScript(bool success)
{
- DCHECK(!m_workerGlobalScope);
- m_workerGlobalScope = static_cast<ServiceWorkerGlobalScope*>(workerGlobalScope);
- client().workerContextStarted(this);
+ DCHECK(m_workerGlobalScope);
+ m_workerGlobalScope->didEvaluateWorkerScript();
+ client().didEvaluateWorkerScript(success);
}
-void ServiceWorkerGlobalScopeProxy::workerGlobalScopeClosed()
+void ServiceWorkerGlobalScopeProxy::didCloseWorkerGlobalScope()
{
// This should never be called because close() is not defined in
// ServiceWorkerGlobalScope.
@@ -298,7 +298,7 @@ void ServiceWorkerGlobalScopeProxy::willDestroyWorkerGlobalScope()
m_workerGlobalScope = nullptr;
}
-void ServiceWorkerGlobalScopeProxy::workerThreadTerminated()
+void ServiceWorkerGlobalScopeProxy::didTerminateWorkerThread()
{
client().workerContextDestroyed();
}
« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h ('k') | third_party/WebKit/Source/web/WebSharedWorkerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698