Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy (Closed)
Patch Set: fix comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
index 8dfb1388a5082aaba15484b3f3e7b6d69bb05e35..f8e0869219312f7009642507516fd66910b79dd6 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
@@ -88,12 +88,12 @@ public:
void reportConsoleMessage(MessageSource, MessageLevel, const String& message, SourceLocation*) override;
void postMessageToPageInspector(const String&) override;
void didLoadWorkerScript(size_t scriptSize, size_t cachedMetadataSize) override;
- void didEvaluateWorkerScript(bool success) override;
+ void didCreateWorkerGlobalScope(WorkerOrWorkletGlobalScope*) override;
void didInitializeWorkerContext() override;
- void workerGlobalScopeStarted(WorkerOrWorkletGlobalScope*) override;
- void workerGlobalScopeClosed() override;
+ void didEvaluateWorkerScript(bool success) override;
+ void didCloseWorkerGlobalScope() override;
void willDestroyWorkerGlobalScope() override;
- void workerThreadTerminated() override;
+ void didTerminateWorkerThread() override;
DECLARE_TRACE();

Powered by Google App Engine
This is Rietveld 408576698