Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy (Closed)
Patch Set: fix comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.h
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
index 7012c156696be532f3a9e2ba6d050c311d3c6a14..4d810de8b2601b3e50eb9c0c8631626326829b28 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
@@ -80,9 +80,9 @@ public:
void reportConsoleMessage(MessageSource, MessageLevel, const String& message, SourceLocation*) override;
void postMessageToPageInspector(const WTF::String&) override;
void didEvaluateWorkerScript(bool success) override { }
- void workerGlobalScopeClosed() override;
- void workerThreadTerminated() override;
+ void didCloseWorkerGlobalScope() override;
void willDestroyWorkerGlobalScope() override { }
+ void didTerminateWorkerThread() override;
// WebFrameClient methods to support resource loading thru the 'shadow page'.
WebApplicationCacheHost* createApplicationCacheHost(WebApplicationCacheHostClient*) override;
@@ -124,9 +124,10 @@ private:
void onScriptLoaderFinished();
static void connectTask(WebMessagePortChannelUniquePtr, ExecutionContext*);
+
// Tasks that are run on the main thread.
- void workerGlobalScopeClosedOnMainThread();
- void workerThreadTerminatedOnMainThread();
+ void didCloseWorkerGlobalScopeOnMainThread();
+ void didTerminateWorkerThreadOnMainThread();
void postMessageToPageInspectorOnMainThread(const String& message);
« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698