Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: extensions/browser/updater/manifest_fetch_data.cc

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)
Patch Set: unending win fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/updater/manifest_fetch_data.cc
diff --git a/extensions/browser/updater/manifest_fetch_data.cc b/extensions/browser/updater/manifest_fetch_data.cc
index 5bec4f6d570c6787841d2248ca5b87609a7abf23..2ad78b7de694b5f3d284da8b01ae91412de8da74 100644
--- a/extensions/browser/updater/manifest_fetch_data.cc
+++ b/extensions/browser/updater/manifest_fetch_data.cc
@@ -20,7 +20,7 @@ namespace {
// Maximum length of an extension manifest update check url, since it is a GET
// request. We want to stay under 2K because of proxies, etc.
-const int kExtensionsManifestMaxURLSize = 2000;
+const size_t kExtensionsManifestMaxURLSize = 2000;
void AddEnabledStateToPing(std::string* ping_value,
const ManifestFetchData::PingData* ping_data) {
@@ -139,7 +139,7 @@ bool ManifestFetchData::AddExtension(const std::string& id,
"x=" + net::EscapeQueryParamValue(base::JoinString(parts, "&"), true);
// Check against our max url size, exempting the first extension added.
- int new_size = full_url_.possibly_invalid_spec().size() + extra.size();
+ size_t new_size = full_url_.possibly_invalid_spec().size() + extra.size();
if (!extension_ids_.empty() && new_size > kExtensionsManifestMaxURLSize) {
UMA_HISTOGRAM_PERCENTAGE("Extensions.UpdateCheckHitUrlSizeLimit", 1);
return false;

Powered by Google App Engine
This is Rietveld 408576698