Decompose //extensions/browser/BUILD.gn

extensions/browser/updater/BUILD.gn

Index: extensions/browser/updater/BUILD.gn
diff --git a/extensions/browser/updater/BUILD.gn b/extensions/browser/updater/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..3ac94e5f6916e490eb3440fd609ab55222fc229d
--- /dev/null
+++ b/extensions/browser/updater/BUILD.gn
@@ -0,0 +1,37 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+source_set("updater") {
+  sources = [
+    "extension_cache.h",
+    "extension_downloader.cc",
+    "extension_downloader.h",
+    "extension_downloader_delegate.cc",
+    "extension_downloader_delegate.h",
+    "extension_downloader_test_delegate.h",
+    "manifest_fetch_data.cc",
+    "manifest_fetch_data.h",
+    "null_extension_cache.cc",
+    "null_extension_cache.h",
+    "request_queue.h",
+    "request_queue_impl.h",
+    "safe_manifest_parser.cc",
+    "safe_manifest_parser.h",
+    "update_client_config.cc",
+    "update_client_config.h",
+    "update_data_provider.cc",
+    "update_data_provider.h",
+    "update_install_shim.cc",
+    "update_install_shim.h",
+    "update_service.cc",
+    "update_service.h",
+    "update_service_factory.cc",
+    "update_service_factory.h",
+  ]
+
+  deps = [
+    "//extensions/strings",
+    "//skia",

[Devlin, 2016/09/14 21:06:52]

Does this need skia?

[Rahul Chaturvedi, 2016/09/14 21:40:17]

Yep.
//extensions/browser/updater/safe_manifest_parser.cc includes,
//extensions/common/extension_utility_messages.h which includes,
//third_party/skia/include/core/SkBitmap.h

In fact, we don't really need //skia in the main //e/b/BUILD.gn, so removed it
from there.

[brettw, 2016/09/14 21:42:21]

If extensions/common uses skia in its public headers, then it should provide
skia as a public_deps. This way we can remove it from here.

[Rahul Chaturvedi, 2016/09/14 22:23:41]

I was hoping to keep this change contained to //extensions/browser. Might as
well fix this now.

Also removed all extra //skia dependencies.

Done.

+  ]
+}