Decompose //extensions/browser/BUILD.gn

extensions/browser/updater/manifest_fetch_data.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/updater/manifest_fetch_data.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "extensions/common/extension.h"
 #include "net/base/escape.h"
 
 namespace extensions {
 
 namespace {
 
 // Maximum length of an extension manifest update check url, since it is a GET
 // request. We want to stay under 2K because of proxies, etc.
-const int kExtensionsManifestMaxURLSize = 2000;
+const size_t kExtensionsManifestMaxURLSize = 2000;
 
 void AddEnabledStateToPing(std::string* ping_value,
                       const ManifestFetchData::PingData* ping_data) {
   *ping_value += "&e=" + std::string(ping_data->is_enabled ? "1" : "0");
   if (!ping_data->is_enabled) {
     // Add a dr=<number> param for each bit set in disable reasons.
     for (int enum_value = 1; enum_value < Extension::DISABLE_REASON_LAST;
          enum_value <<= 1) {
       if (ping_data->disable_reasons & enum_value)
         *ping_value += "&dr=" + base::IntToString(enum_value);
@@ skipping 98 matching lines @@
     }
     if (!ping_value.empty())
       parts.push_back("ping=" + net::EscapeQueryParamValue(ping_value, true));
   }
 
   std::string extra = full_url_.has_query() ? "&" : "?";
   extra +=
       "x=" + net::EscapeQueryParamValue(base::JoinString(parts, "&"), true);
 
   // Check against our max url size, exempting the first extension added.
-  int new_size = full_url_.possibly_invalid_spec().size() + extra.size();
+  size_t new_size = full_url_.possibly_invalid_spec().size() + extra.size();
   if (!extension_ids_.empty() && new_size > kExtensionsManifestMaxURLSize) {
     UMA_HISTOGRAM_PERCENTAGE("Extensions.UpdateCheckHitUrlSizeLimit", 1);
     return false;
   }
   UMA_HISTOGRAM_PERCENTAGE("Extensions.UpdateCheckHitUrlSizeLimit", 0);
 
   // We have room so go ahead and add the extension.
   extension_ids_.insert(id);
   full_url_ = GURL(full_url_.possibly_invalid_spec() + extra);
   return true;
@@ skipping 17 matching lines @@
     NOTREACHED();
   return value == kNeverPinged || value > 0;
 }
 
 void ManifestFetchData::Merge(const ManifestFetchData& other) {
   DCHECK(full_url() == other.full_url());
   request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
 }
 
 }  // namespace extensions