Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2035)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)
Patch Set: unending win fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index 85e192177e06956ac0921f331e42ea8fd65cea66..e24267b40dad5aee06e24a7812cddcca9d0853b0 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -126,7 +126,7 @@ bool IncrementAuthUserIndex(GURL* url) {
int user_index = 0;
std::string old_query = url->query();
std::vector<std::string> new_query_parts;
- url::Component query(0, old_query.length());
+ url::Component query(0, static_cast<int>(old_query.length()));
url::Component key, value;
while (url::ExtractQueryKeyValue(old_query.c_str(), &query, &key, &value)) {
std::string key_string = old_query.substr(key.begin, key.len);
@@ -143,7 +143,7 @@ bool IncrementAuthUserIndex(GURL* url) {
new_query_parts.push_back(
base::StringPrintf("%s=%d", kAuthUserQueryKey, user_index + 1));
std::string new_query_string = base::JoinString(new_query_parts, "&");
- url::Component new_query(0, new_query_string.size());
+ url::Component new_query(0, static_cast<int>(new_query_string.size()));
url::Replacements<char> replacements;
replacements.SetQuery(new_query_string.c_str(), new_query);
*url = url->ReplaceComponents(replacements);
@@ -443,7 +443,8 @@ void ExtensionDownloader::StartUpdateCheck(
} else {
UMA_HISTOGRAM_COUNTS(
"Extensions.UpdateCheckUrlLength",
- fetch_data->full_url().possibly_invalid_spec().length());
+ static_cast<int>(
+ fetch_data->full_url().possibly_invalid_spec().length()));
manifests_queue_.ScheduleRequest(std::move(fetch_data));
}
@@ -578,8 +579,8 @@ void ExtensionDownloader::HandleManifestResults(
if (!crx_url.SchemeIsCryptographic()) {
url::Replacements<char> replacements;
std::string scheme("https");
- replacements.SetScheme(scheme.c_str(),
- url::Component(0, scheme.size()));
+ replacements.SetScheme(
+ scheme.c_str(), url::Component(0, static_cast<int>(scheme.size())));
crx_url = crx_url.ReplaceComponents(replacements);
}
}
@@ -664,7 +665,7 @@ void ExtensionDownloader::DetermineUpdates(
continue;
}
VLOG(2) << "will try to update " << id;
- result->push_back(i);
+ result->push_back(static_cast<int>(i));
}
}

Powered by Google App Engine
This is Rietveld 408576698