Lots of little cleanup improvements to Vulkan

Lots of little cleanup improvements to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336763002

Committed: https://skia.googlesource.com/skia/+/ec44099979acd3e83ad93a15dbd9301856a90572

[egdaniel, 2016-09-12 20:36:30]

Description was changed from

==========
Lots of little cleanup improvements to Vulkan

BUG=skia:
==========

to

==========
Lots of little cleanup improvements to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336763002
==========

[egdaniel, 2016-09-12 20:40:08]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com

[egdaniel, 2016-09-12 20:40:09]

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:105: if (fIsEmpty && !fHasClearStart) {
If we grab a texture to which we immediately want to copy to (like dst copy),
grabbing the texture will be a discard batch in, but then when won't actually do
any real work besides a discard. So this allows us to just skip these commands.

[Brian Osman, 2016-09-12 20:45:05]

lgtm with grammar nit

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:106: // We have sumbitted now actual draw
commands the the command buffer and we are not using
s/now/no/ ?
s/the the/to the/ ?

[jvanverth1, 2016-09-12 20:48:23]

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:106: // We have sumbitted now actual draw
commands the the command buffer and we are not using
submitted no actual draw commands to the

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.h (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.h:66: bool                       
fHasClearStart;
This sounds like it didn't foul on the starting line. fStartsWithClear, maybe?
Also seems to always be false.

[egdaniel, 2016-09-12 21:14:32]

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:106: // We have sumbitted now actual draw
commands the the command buffer and we are not using
On 2016/09/12 20:45:05, Brian Osman wrote:
> s/now/no/ ?
> s/the the/to the/ ?

Done.

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
File src/gpu/vk/GrVkGpuCommandBuffer.h (right):

https://codereview.chromium.org/2336763002/diff/1/src/gpu/vk/GrVkGpuCommandBu...
src/gpu/vk/GrVkGpuCommandBuffer.h:66: bool                       
fHasClearStart;
On 2016/09/12 20:48:23, jvanverth1 wrote:
> This sounds like it didn't foul on the starting line. fStartsWithClear, maybe?
> Also seems to always be false.

Done. And forgot to save/commit the change that set this...

[egdaniel, 2016-09-13 14:40:29]

jim are you good with updates?

[egdaniel, 2016-09-13 15:10:01]

The CQ bit was checked by egdaniel@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 15:10:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jvanverth1, 2016-09-13 15:18:51]

lgtm

[commit-bot: I haz the power, 2016-09-13 15:53:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 15:53:05]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-09-13 16:53:12]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-09-13 16:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/2336763002/#ps20001
(title: "[")

[commit-bot: I haz the power, 2016-09-13 16:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 16:54:12]

Description was changed from

==========
Lots of little cleanup improvements to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336763002
==========

to

==========
Lots of little cleanup improvements to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336763002

Committed:
https://skia.googlesource.com/skia/+/ec44099979acd3e83ad93a15dbd9301856a90572
==========

[commit-bot: I haz the power, 2016-09-13 16:54:13]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ec44099979acd3e83ad93a15dbd9301856a90572