Create SkLayerRasterizer w/o destroying Builder.

Create SkLayerRasterizer w/o destroying Builder.

Add a new method to SkLayerRasterizer::Builder that creates a new
SkLayerRasterizer without destroying the Builder. Necessary to
continue to support Android's API.

Also fix a bug where creating a Builder and never calling
detachRasterizer results in not calling the destructor for any SkPaints
in the Builder.

Add tests.

BUG=b/13729784

Committed: http://code.google.com/p/skia/source/detail?r=14139

[reed1, 2014-04-10 19:53:03]

https://codereview.chromium.org/233673002/diff/20001/include/effects/SkLayerR...
File include/effects/SkLayerRasterizer.h (right):

https://codereview.chromium.org/233673002/diff/20001/include/effects/SkLayerR...
include/effects/SkLayerRasterizer.h:48: *  *may* be used after calling this
function.
Builder b;
b.addLayer(A)
x = b.copyRasterizer
b.addLayer(B)
y = b.copyRasterizer // or b.detachRasterizer

What is in x?
What is in y?

[scroggo, 2014-04-10 20:14:23]

https://codereview.chromium.org/233673002/diff/20001/include/effects/SkLayerR...
File include/effects/SkLayerRasterizer.h (right):

https://codereview.chromium.org/233673002/diff/20001/include/effects/SkLayerR...
include/effects/SkLayerRasterizer.h:48: *  *may* be used after calling this
function.
On 2014/04/10 19:53:04, reed1 wrote:
> Builder b;
> b.addLayer(A)
> x = b.copyRasterizer
> b.addLayer(B)
> y = b.copyRasterizer // or b.detachRasterizer
> 
> What is in x?
> What is in y?

Latest patch clarifies things.

[reed1, 2014-04-10 20:16:42]

lgtm

https://codereview.chromium.org/233673002/diff/40001/include/effects/SkLayerR...
File include/effects/SkLayerRasterizer.h (right):

https://codereview.chromium.org/233673002/diff/40001/include/effects/SkLayerR...
include/effects/SkLayerRasterizer.h:60: SkLayerRasterizer* snapshotRasterizer()
const;
can this guy be const? Does it have to be? I'd be fine if it wasn't, but I leave
that to you.

[scroggo, 2014-04-10 20:21:37]

https://codereview.chromium.org/233673002/diff/40001/include/effects/SkLayerR...
File include/effects/SkLayerRasterizer.h (right):

https://codereview.chromium.org/233673002/diff/40001/include/effects/SkLayerR...
include/effects/SkLayerRasterizer.h:60: SkLayerRasterizer* snapshotRasterizer()
const;
On 2014/04/10 20:16:42, reed1 wrote:
> can this guy be const? Does it have to be? I'd be fine if it wasn't, but I
leave
> that to you.

As stated in person, it can, but does not have to be const. I like declaring it
const because the whole point of this function is that it returns a layer
rasterizer without modifying the builder.

[scroggo, 2014-04-10 20:21:40]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-04-10 20:21:52]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/scroggo@google.com/233673002/40001

[commit-bot: I haz the power, 2014-04-10 20:42:56]

Change committed as 14139