Add Milo URLs to list of flakes

Add Milo URLs to list of flakes

R=estaab@chromium.org
BUG=646055
Committed: https://chromium.googlesource.com/infra/infra/+/a0d064e40aef576529384258f022f965556be1d4

[estaab, 2016-09-12 18:55:38]

estaab@chromium.org changed reviewers:
+ hinoka@chromium.org

[estaab, 2016-09-12 18:55:39]

+hinoka

Looks good but I'll let Ryan do the actual review to make sure the URLs look
right and he's ok with this.

[hinoka, 2016-09-12 20:22:09]

https://codereview.chromium.org/2336713002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/model/build_run.py (right):

https://codereview.chromium.org/2336713002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/model/build_run.py:51: return
('https://luci-milo.appspot.com/logdog/build/chromium/bb/' +
I'd recommend the /buildbot/<master>/<builder>/<build #> URL instead.  The
logdog ones certainly work, but:
* Internal masters will need to be /chrome/ instead of /chromium/
* Lack of backlinks to builder view
* the /logdog/ urls wasn't originally intended for production use, just a way to
see annotation protos from logdog meanwhile we worked on integrating them into
their respective endpoints (/buildbot/ and /swarming/)
* The logdog view doesn't contain builds where it doesn't get as far as logdog
(or hung builds... apperently)
* the /buildbot/ url will be backed by logdog in a couple weeks anyways
(crbug.com/644363)

[Sergiy Byelozyorov, 2016-09-12 22:34:57]

https://codereview.chromium.org/2336713002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/model/build_run.py (right):

https://codereview.chromium.org/2336713002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/model/build_run.py:51: return
('https://luci-milo.appspot.com/logdog/build/chromium/bb/' +
On 2016/09/12 20:22:08, hinoka wrote:
> I'd recommend the /buildbot/<master>/<builder>/<build #> URL instead.  The
> logdog ones certainly work, but:
> * Internal masters will need to be /chrome/ instead of /chromium/
> * Lack of backlinks to builder view
> * the /logdog/ urls wasn't originally intended for production use, just a way
to
> see annotation protos from logdog meanwhile we worked on integrating them into
> their respective endpoints (/buildbot/ and /swarming/)
> * The logdog view doesn't contain builds where it doesn't get as far as logdog
> (or hung builds... apperently)
> * the /buildbot/ url will be backed by logdog in a couple weeks anyways
> (crbug.com/644363)

Done.

[hinoka, 2016-09-12 22:36:14]

lgtm

[Sergiy Byelozyorov, 2016-09-12 23:01:52]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:01:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:16:04]

Description was changed from

==========
Add Milo URLs to list of flakes

R=estaab@chromium.org
BUG=646055
==========

to

==========
Add Milo URLs to list of flakes

R=estaab@chromium.org
BUG=646055

Committed:
https://chromium.googlesource.com/infra/infra/+/a0d064e40aef576529384258f022f...
==========

[commit-bot: I haz the power, 2016-09-12 23:16:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/a0d064e40aef576529384258f022f...