Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3032)

Unified Diff: appengine/chromium_try_flakes/model/build_run.py

Issue 2336713002: Add Milo URLs to list of flakes (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_try_flakes/model/build_run.py
diff --git a/appengine/chromium_try_flakes/model/build_run.py b/appengine/chromium_try_flakes/model/build_run.py
index 3ba6f2ebadabc6a8556685b658d058c23bcb8d89..f105cba2d1f9664ba63a8daed8f919b628498ced 100644
--- a/appengine/chromium_try_flakes/model/build_run.py
+++ b/appengine/chromium_try_flakes/model/build_run.py
@@ -43,6 +43,15 @@ class BuildRun(ndb.Model): # pragma: no cover
self.removeMasterPrefix(parent.master) + '/builders/' +
parent.builder + '/builds/' + str(self.buildnumber))
+ def getMiloURL(self):
+ # In July 2016, protobuf changed and URLs for earlier builds do not open.
+ if self.time_finished < datetime.datetime(2016, 8, 1):
+ return
+ parent = self.key.parent().get()
+ return ('https://luci-milo.appspot.com/buildbot/' +
+ self.removeMasterPrefix(parent.master) + '/' + parent.builder +
+ '/' + str(self.buildnumber))
+
buildnumber = ndb.IntegerProperty(required=True)
result = ndb.IntegerProperty(required=True)
time_finished = ndb.DateTimeProperty(required=True)

Powered by Google App Engine
This is Rietveld 408576698