Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Unified Diff: appengine/chromium_try_flakes/handlers/all_flake_occurrences.py

Issue 2336713002: Add Milo URLs to list of flakes (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/chromium_try_flakes/handlers/test/all_flake_occurrences_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_try_flakes/handlers/all_flake_occurrences.py
diff --git a/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py b/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py
index 87201872043f90f21357d184c8a5571c3c4b357f..64fd7e90c66a8c048acae8acb9080fcb08959ade 100644
--- a/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py
+++ b/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py
@@ -54,9 +54,10 @@ def show_all_flakes(flake, show_all):
patchsets = filterNone(ndb.get_multi(patchsets_keys))
class FailureRunExtended:
- def __init__(self, url, patchset_url, builder, formatted_time, issue_ids,
- time_finished):
+ def __init__(self, url, milo_url, patchset_url, builder, formatted_time,
+ issue_ids, time_finished):
self.url = url
+ self.milo_url = milo_url
self.patchset_url = patchset_url
self.builder = builder
self.formatted_time = formatted_time
@@ -67,6 +68,7 @@ def show_all_flakes(flake, show_all):
for index, fr in enumerate(failure_runs):
failure_runs_extended.append(FailureRunExtended(
fr.getURL(),
+ fr.getMiloURL(),
patchsets[index].getURL(),
patchsets[index].builder,
fr.time_finished.strftime('%Y-%m-%d %H:%M:%S UTC'),
« no previous file with comments | « no previous file | appengine/chromium_try_flakes/handlers/test/all_flake_occurrences_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698