Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2336673002: Reland of [ash-md] Fades overview header in and out (Closed)

Created:
4 years, 3 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
sky, bruthig
CC:
chromium-reviews, kalyank, sadrul, tfarina, dmurph
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [ash-md] Fades overview header in and out This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec. This creates a visually smoother transition into overview mode than before. Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item. --- This relands https://codereview.chromium.org/2239233002/ and reverts commit 758e34e4a30be65c2cedf5fb2a893fa3a87596f0. Corrects lifetime manipulation of the child views after their ownership it taken over by a CleanupAnimationObserver. BUG=624608, 645076, 645708 TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt. Committed: https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31 Cr-Commit-Position: refs/heads/master@{#418017}

Patch Set 1 #

Patch Set 2 : Fixes use-after-free for the views that get destroyed synchronously in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -238 lines) Patch
M ash/aura/wm_window_aura.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M ash/common/frame/custom_frame_view_ash.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/frame/default_header_painter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/frame/default_header_painter.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/common/frame/header_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/frame/header_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/common/wm/overview/overview_animation_type.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/scoped_overview_animation_settings.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.h View 5 chunks +18 lines, -9 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 7 chunks +59 lines, -37 lines 0 comments Download
M ash/common/wm/overview/window_grid.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_grid.cc View 7 chunks +36 lines, -31 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 11 chunks +52 lines, -7 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 1 22 chunks +345 lines, -119 lines 0 comments Download
M ash/common/wm_window.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/wm_window_property.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_aura.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_aura.cc View 4 chunks +43 lines, -21 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 17 chunks +35 lines, -8 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
varkha
sky@, bruthig@, Please take a look - trying to re-land after it failed in tests ...
4 years, 3 months ago (2016-09-12 17:00:50 UTC) #5
bruthig
lgtm
4 years, 3 months ago (2016-09-12 17:43:06 UTC) #6
sky
LGTM
4 years, 3 months ago (2016-09-12 18:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336673002/20001
4 years, 3 months ago (2016-09-12 18:58:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 20:07:51 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 20:10:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31
Cr-Commit-Position: refs/heads/master@{#418017}

Powered by Google App Engine
This is Rietveld 408576698