ash/common/frame/default_header_painter.h - Issue 2336673002: Reland of [ash-md] Fades overview header in and out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/frame/default_header_painter.h

Issue 2336673002: Reland of [ash-md] Fades overview header in and out (Closed)

Patch Set: Fixes use-after-free for the views that get destroyed synchronously in tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/frame/default_header_painter.h

diff --git a/ash/common/frame/default_header_painter.h b/ash/common/frame/default_header_painter.h

index d9ea50c944aeb3d25c971d270d0690fc4d9b5400..4f5980de49c892192934c50ff85bbe5f5a69abc4 100644

--- a/ash/common/frame/default_header_painter.h

+++ b/ash/common/frame/default_header_painter.h

@@ -55,6 +55,8 @@ class ASH_EXPORT DefaultHeaderPainter : public HeaderPainter,

// Sets the active and inactive frame colors. Note the inactive frame color

// will have some transparency added when the frame is drawn.

void SetFrameColors(SkColor active_frame_color, SkColor inactive_frame_color);

+ SkColor GetActiveFrameColor() const;

+ SkColor GetInactiveFrameColor() const;

private:

FRIEND_TEST_ALL_PREFIXES(DefaultHeaderPainterTest, TitleIconAlignment);