Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2336513003: Add back the GalaxyS3 and GalaxyS4 entries in recipes (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add back the GalaxyS3 and GalaxyS4 entries in recipes S3 is needed for some recipe simulation stuff and in general having these present does not hurt us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003 Committed: https://skia.googlesource.com/skia/+/ea5de1ff1dcdbfbf3e4314dc151dd1a03023cbb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M infra/bots/recipe_modules/flavor/android_flavor.py View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
borenet
4 years, 3 months ago (2016-09-12 20:01:23 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-09-12 20:32:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336513003/1
4 years, 3 months ago (2016-09-12 21:01:14 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:02:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea5de1ff1dcdbfbf3e4314dc151dd1a03023cbb1

Powered by Google App Engine
This is Rietveld 408576698