Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: infra/bots/recipes/swarm_trigger.py

Issue 2336513003: Add back the GalaxyS3 and GalaxyS4 entries in recipes (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/recipe_modules/flavor/android_flavor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_trigger.py
diff --git a/infra/bots/recipes/swarm_trigger.py b/infra/bots/recipes/swarm_trigger.py
index 8a61fdad525dafc46433db3e06d62feff59ce025..570b1eaf803a5a383be4f37a42622a55668e9bbf 100644
--- a/infra/bots/recipes/swarm_trigger.py
+++ b/infra/bots/recipes/swarm_trigger.py
@@ -113,6 +113,8 @@ def swarm_dimensions(builder_cfg):
# For Android, the device type is a better dimension than CPU or GPU.
dimensions['device_type'] = {
'AndroidOne': 'sprout',
+ 'GalaxyS3': 'm0', #'smdk4x12', Detected incorrectly by swarming?
+ 'GalaxyS4': None, # TODO(borenet,kjlubick)
'GalaxyS7': 'heroqlteatt',
'NVIDIA_Shield': 'foster',
'Nexus10': 'manta',
« no previous file with comments | « infra/bots/recipe_modules/flavor/android_flavor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698