Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: infra/bots/recipes/swarm_trigger.py

Issue 2336513003: Add back the GalaxyS3 and GalaxyS4 entries in recipes (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « infra/bots/recipe_modules/flavor/android_flavor.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # Recipe module for Skia Swarming trigger. 6 # Recipe module for Skia Swarming trigger.
7 7
8 8
9 import os 9 import os
10 import json 10 import json
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 if builder_cfg.get('extra_config', '').startswith('CT_'): 106 if builder_cfg.get('extra_config', '').startswith('CT_'):
107 dimensions['pool'] = 'SkiaCT' 107 dimensions['pool'] = 'SkiaCT'
108 return dimensions # Do not need any more dimensions for CT builders. 108 return dimensions # Do not need any more dimensions for CT builders.
109 if 'Win' in builder_cfg.get('os', ''): 109 if 'Win' in builder_cfg.get('os', ''):
110 dimensions['os'] = 'Windows' 110 dimensions['os'] = 'Windows'
111 if builder_cfg['role'] in ('Test', 'Perf'): 111 if builder_cfg['role'] in ('Test', 'Perf'):
112 if 'Android' in builder_cfg['os']: 112 if 'Android' in builder_cfg['os']:
113 # For Android, the device type is a better dimension than CPU or GPU. 113 # For Android, the device type is a better dimension than CPU or GPU.
114 dimensions['device_type'] = { 114 dimensions['device_type'] = {
115 'AndroidOne': 'sprout', 115 'AndroidOne': 'sprout',
116 'GalaxyS3': 'm0', #'smdk4x12', Detected incorrectly by swarming?
117 'GalaxyS4': None, # TODO(borenet,kjlubick)
116 'GalaxyS7': 'heroqlteatt', 118 'GalaxyS7': 'heroqlteatt',
117 'NVIDIA_Shield': 'foster', 119 'NVIDIA_Shield': 'foster',
118 'Nexus10': 'manta', 120 'Nexus10': 'manta',
119 'Nexus5': 'hammerhead', 121 'Nexus5': 'hammerhead',
120 'Nexus6': 'shamu', 122 'Nexus6': 'shamu',
121 'Nexus6p': 'angler', 123 'Nexus6p': 'angler',
122 'Nexus7': 'grouper', 124 'Nexus7': 'grouper',
123 'Nexus7v2': 'flo', 125 'Nexus7v2': 'flo',
124 'Nexus9': 'flounder', 126 'Nexus9': 'flounder',
125 'NexusPlayer': 'fugu', 127 'NexusPlayer': 'fugu',
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 mastername='client.skia', 817 mastername='client.skia',
816 slavename='skiabot-linux-swarm-000', 818 slavename='skiabot-linux-swarm-000',
817 buildnumber=5, 819 buildnumber=5,
818 path_config='kitchen', 820 path_config='kitchen',
819 revision='abc123', 821 revision='abc123',
820 **gerrit_kwargs) + 822 **gerrit_kwargs) +
821 api.step_data( 823 api.step_data(
822 'upload new .isolated file for test_skia', 824 'upload new .isolated file for test_skia',
823 stdout=api.raw_io.output('def456 XYZ.isolated')) 825 stdout=api.raw_io.output('def456 XYZ.isolated'))
824 ) 826 )
OLDNEW
« no previous file with comments | « infra/bots/recipe_modules/flavor/android_flavor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698