third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php - Issue 2336273003: Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php

Issue 2336273003: Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect() (Closed)

Patch Set: Remove the 308 test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-credentials.html ('k') | third_party/WebKit/Source/core/loader/PingLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php b/third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php

index a43ff62c29929a8604040105ebf7b80ebe87d535..1888c9329cc5bdbd380cf21a39a513310e89488e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php

@@ -32,6 +32,9 @@ if (strpos($contentType, "application/") !== false) {

fwrite($beaconFile, "Body: $postdata\n");

fclose($beaconFile);

rename($beaconFilename . ".tmp", $beaconFilename);

-foreach ($_COOKIE as $name => $value)

- setcookie($name, "deleted", time() - 60, "/");

+if (!array_key_exists('dontclearcookies', $_GET)) {

+ foreach ($_COOKIE as $name => $value)

+ setcookie($name, "deleted", time() - 60, "/");