Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect()

Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297
Committed: https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6
Cr-Commit-Position: refs/heads/master@{#427048}

[tyoshino (SeeGerritForStatus), 2016-09-14 14:12:19]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[tyoshino (SeeGerritForStatus), 2016-09-14 14:12:28]

The CQ bit was unchecked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-14 14:13:55]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:14:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:41:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tyoshino (SeeGerritForStatus), 2016-09-16 07:50:23]

Description was changed from

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

BUG=636297
==========

to

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

BUG=636297
==========

[tyoshino (SeeGerritForStatus), 2016-09-16 07:50:23]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-16 07:50:36]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 07:50:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 07:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 07:54:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-09-26 07:45:22]

The code change looks fine, but the tests don't agree. Mind taking another look?

(Sorry, I've been OOO.)

[tyoshino (SeeGerritForStatus), 2016-09-26 09:20:45]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 09:21:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 10:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 10:18:45]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tyoshino (SeeGerritForStatus), 2016-09-26 14:46:31]

On 2016/09/26 07:45:22, Mike West (OOO until 26th) wrote:
> The code change looks fine, but the tests don't agree. Mind taking another
look?
> 
> (Sorry, I've been OOO.)

Oh, sorry. The bots were red because of some trouble in them.

I ran CQ dry-run again, but the layout tests are failing on the bots while they
pass on my workstation. I'm investigating now.

[tyoshino (SeeGerritForStatus), 2016-10-20 11:17:52]

It turned out that the test case about the status code 308 is causing the bot
failure.

I've split the layout tests into a separate CL, and running on the bots to see
whether the change is related to the failure or not.
https://codereview.chromium.org/2438723002/

If it turns out that the bots fail even without the change to PingLoader, I'd
like to omit the 308 test and file a bug about it, and proceed to land the
change to PingLoader.cpp.

[tyoshino (SeeGerritForStatus), 2016-10-20 14:33:50]

On 2016/10/20 11:17:52, tyoshino wrote:
> It turned out that the test case about the status code 308 is causing the bot
> failure.
> 
> I've split the layout tests into a separate CL, and running on the bots to see
> whether the change is related to the failure or not.
> https://codereview.chromium.org/2438723002/
> 
> If it turns out that the bots fail even without the change to PingLoader, I'd
> like to omit the 308 test and file a bug about it, and proceed to land the
> change to PingLoader.cpp.

The rel_ng bots failed without the change to PingLoader.
https://codereview.chromium.org/2438723002/

So, there should be some bug regarding 308 or my test is incorrect for testing
308.

Anyway, the change to PingLoader.cpp can be landed, I think.

PTAL, Mike.

[tyoshino (SeeGerritForStatus), 2016-10-20 14:33:55]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 14:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 17:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:09:12]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-10-21 05:52:31]

tyoshino@chromium.org changed reviewers:
+ yhirano@chromium.org

[tyoshino (SeeGerritForStatus), 2016-10-21 05:52:44]

On 2016/10/20 14:33:50, tyoshino wrote:
> On 2016/10/20 11:17:52, tyoshino wrote:
> > It turned out that the test case about the status code 308 is causing the
bot
> > failure.
> > 
> > I've split the layout tests into a separate CL, and running on the bots to
see
> > whether the change is related to the failure or not.
> > https://codereview.chromium.org/2438723002/
> > 
> > If it turns out that the bots fail even without the change to PingLoader,
I'd
> > like to omit the 308 test and file a bug about it, and proceed to land the
> > change to PingLoader.cpp.
> 
> The rel_ng bots failed without the change to PingLoader.
> https://codereview.chromium.org/2438723002/
> 
> So, there should be some bug regarding 308 or my test is incorrect for testing
> 308.
> 
> Anyway, the change to PingLoader.cpp can be landed, I think.
> 
> PTAL, Mike.

Adding Yutaka for balancing load.

[Mike West, 2016-10-23 05:29:31]

LGTM.

[tyoshino (SeeGerritForStatus), 2016-10-24 07:04:54]

Description was changed from

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

BUG=636297
==========

to

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297
==========

[tyoshino (SeeGerritForStatus), 2016-10-24 07:05:23]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-10-24 07:05:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-10-24 07:45:38]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-10-24 07:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2336273003/#ps240001
(title: "Remove the 308 test")

[commit-bot: I haz the power, 2016-10-24 07:45:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 09:56:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 09:56:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tyoshino (SeeGerritForStatus), 2016-10-24 11:00:43]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-10-24 11:01:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 11:50:27]

Description was changed from

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297
==========

to

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297
==========

[commit-bot: I haz the power, 2016-10-24 11:50:28]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-10-24 11:52:36]

Description was changed from

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297
==========

to

==========
Remove unnecessary setAllowStoredCredentials() call in
PingLoader::willFollowRedirect()

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297

Committed: https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6
Cr-Commit-Position: refs/heads/master@{#427048}
==========

[commit-bot: I haz the power, 2016-10-24 11:52:38]

Patchset 13 (id:??) landed as
https://crrev.com/fbff05cfbc1af00ed8391f87ad49d23f632eddd6
Cr-Commit-Position: refs/heads/master@{#427048}