Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2336273003: Remove unnecessary setAllowStoredCredentials() call in PingLoader::willFollowRedirect() (Closed)
Patch Set: Remove the 308 test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/PingLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp
index f8c7ad698e6033d2916fb52d78e0f6d43f3cda2d..2a1ab60b91b51ee25d2d484f1dae7b85b077c446 100644
--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp
@@ -295,12 +295,11 @@ bool PingLoaderImpl::willFollowRedirect(
if (!m_isBeacon)
return true;
- // TODO(tyoshino): Check if setAllowStoredCredentials() should be called also
- // for non beacon cases.
- passedNewRequest.setAllowStoredCredentials(true);
if (m_corsMode == NotCORSEnabled)
return true;
+ DCHECK(passedNewRequest.allowStoredCredentials());
+
ResourceRequest& newRequest(passedNewRequest.toMutableResourceRequest());
const ResourceResponse& redirectResponse(
passedRedirectResponse.toResourceResponse());
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/navigation/resources/save-beacon.php ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698