mash: Port ash_sysui app list presenter to mojo:ash.

mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300, 616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org

Committed: https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05
Cr-Commit-Position: refs/heads/master@{#418181}

[msw, 2016-09-12 21:28:16]

Description was changed from

==========
mash: Port ash_sysui app list presenter to mojo:ash.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=mfomitchev@chromium.org
==========

to

==========
mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org
==========

[msw, 2016-09-12 21:28:16]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-09-12 21:31:25]

Hey Scott, please take a look; thanks! (FYI, Mikhail.)

[msw, 2016-09-12 21:31:30]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2016-09-12 22:39:21]

Thank you for doing this!

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (left):

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:12: // TODO(mfomitchev): Remove when
http://crbug.com/607300 is fixed.
Have you confirmed the issue fixed now? (I haven't been following Rob's and
Kyle's work closely enough to tell without testing myself).

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.h (right):

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.h:53: shell::Connector* connector_;
I'd initialize connector_ before the app list presenter - just in case :)

https://codereview.chromium.org/2335833002/diff/40001/chrome/app/mojo/chrome_...
File chrome/app/mojo/chrome_manifest.json (left):

https://codereview.chromium.org/2335833002/diff/40001/chrome/app/mojo/chrome_...
chrome/app/mojo/chrome_manifest.json:22: "app_list:presenter": [
"app_list::mojom::AppListPresenter" ]
It used to be that if one interface was declared as provided - all needed to be
declared as provided, or else the Shell would deny the connection. Has that
changed?

[commit-bot: I haz the power, 2016-09-12 22:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 22:46:49]

Dry run: This issue passed the CQ dry run.

[msw, 2016-09-12 22:52:09]

Please take another look; thanks!

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (left):

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:12: // TODO(mfomitchev): Remove when
http://crbug.com/607300 is fixed.
On 2016/09/12 22:39:20, mfomitchev wrote:
> Have you confirmed the issue fixed now? (I haven't been following Rob's and
> Kyle's work closely enough to tell without testing myself).

Indeed, it's fixed for this use case. Mus and Mash use the same ids.

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.h (right):

https://codereview.chromium.org/2335833002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.h:53: shell::Connector* connector_;
On 2016/09/12 22:39:20, mfomitchev wrote:
> I'd initialize connector_ before the app list presenter - just in case :)

Done.

https://codereview.chromium.org/2335833002/diff/40001/chrome/app/mojo/chrome_...
File chrome/app/mojo/chrome_manifest.json (left):

https://codereview.chromium.org/2335833002/diff/40001/chrome/app/mojo/chrome_...
chrome/app/mojo/chrome_manifest.json:22: "app_list:presenter": [
"app_list::mojom::AppListPresenter" ]
On 2016/09/12 22:39:21, mfomitchev wrote:
> It used to be that if one interface was declared as provided - all needed to
be
> declared as provided, or else the Shell would deny the connection. Has that
> changed?

I was never aware of that requirement, perhaps that was just for classes and not
interfaces? I'm removing this class (containing just a single interface) and
just listing the interface directly in mash's manifest; that works fine, afaict.

[msw, 2016-09-12 22:52:14]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 22:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 00:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 00:09:21]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-13 02:00:23]

LGTM

[msw, 2016-09-13 05:59:42]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-09-13 05:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 06:03:42]

Description was changed from

==========
mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org
==========

to

==========
mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org
==========

[commit-bot: I haz the power, 2016-09-13 06:03:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 06:05:44]

Description was changed from

==========
mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org
==========

to

==========
mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG=607300,616857
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org

Committed: https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05
Cr-Commit-Position: refs/heads/master@{#418181}
==========

[commit-bot: I haz the power, 2016-09-13 06:05:45]

Patchset 4 (id:??) landed as
https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05
Cr-Commit-Position: refs/heads/master@{#418181}