mash: Port ash_sysui app list presenter to mojo:ash.

ash/mus/app_list_presenter_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ash/sysui/app_list_presenter_mus.h"
+#include "ash/mus/app_list_presenter_mus.h"
 
 #include "services/shell/public/cpp/connector.h"
 
 namespace ash {
+
 namespace {
 
-// TODO(mfomitchev): Remove when http://crbug.com/607300 is fixed.

[mfomitchev, 2016/09/12 22:39:20]

Have you confirmed the issue fixed now? (I haven't been following Rob's and
Kyle's work closely enough to tell without testing myself).

[msw, 2016/09/12 22:52:09]

Indeed, it's fixed for this use case. Mus and Mash use the same ids. 

-// This method should not exist. Sys_ui has different display ids because it
-// uses ScreenAsh instead of ScreenMus.
-int64_t GetMusDisplayId(int64_t sysui_display_id) {
-  return 1;
-}
-
 bool HasConnection(app_list::mojom::AppListPresenterPtr* interface_ptr) {
   return interface_ptr->is_bound() && !interface_ptr->encountered_error();
 }
 
 }  // namespace
 
 AppListPresenterMus::AppListPresenterMus(::shell::Connector* connector)
-    : connector_(connector) {
-  ConnectIfNeeded();
-}
+    : connector_(connector) {}
 
 AppListPresenterMus::~AppListPresenterMus() {}
 
 void AppListPresenterMus::Show(int64_t display_id) {
-  display_id = GetMusDisplayId(display_id);
+  ConnectIfNeeded();
   presenter_->Show(display_id);
 }
 
 void AppListPresenterMus::Dismiss() {
   ConnectIfNeeded();
   presenter_->Dismiss();
 }
 
 void AppListPresenterMus::ToggleAppList(int64_t display_id) {
-  display_id = GetMusDisplayId(display_id);
   ConnectIfNeeded();
   presenter_->ToggleAppList(display_id);
 }
 
 bool AppListPresenterMus::IsVisible() const {
   return false;
 }
 
 bool AppListPresenterMus::GetTargetVisibility() const {
   // TODO(mfomitchev): we have GetTargetVisibility() in mojom, but this
   // shouldn't be a synchronous method. We should go through the call sites and
   // either teach them to use a callback, or perhaps use a visibility observer.
   //  NOTIMPLEMENTED();
   return false;
 }
 
-bool AppListPresenterMus::ConnectIfNeeded() {
-  if (HasConnection(&presenter_))
-    return true;
+void AppListPresenterMus::ConnectIfNeeded() {
+  if (!connector_ || HasConnection(&presenter_))
+    return;
   connector_->ConnectToInterface("exe:chrome", &presenter_);
   CHECK(HasConnection(&presenter_))
       << "Could not connect to app_list::mojom::AppListPresenter.";
-  return true;
 }
 
 }  // namespace ash