Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: ash/mus/window_manager.cc

Issue 2335833002: mash: Port ash_sysui app list presenter to mojo:ash. (Closed)
Patch Set: Reorder ShellDelegateMus members. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/shell_delegate_mus.cc ('k') | ash/sysui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index 69a2992a7c08fb222113a7bf0d9fe96b2881f42e..30150441f26f82722465378442dbd3322ca80850 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -11,6 +11,7 @@
#include "ash/common/shell_window_ids.h"
#include "ash/mus/accelerators/accelerator_handler.h"
#include "ash/mus/accelerators/accelerator_ids.h"
+#include "ash/mus/app_list_presenter_mus.h"
#include "ash/mus/bridge/wm_lookup_mus.h"
#include "ash/mus/bridge/wm_shell_mus.h"
#include "ash/mus/bridge/wm_window_mus.h"
@@ -22,6 +23,7 @@
#include "ash/mus/shell_delegate_mus.h"
#include "ash/mus/window_manager_observer.h"
#include "ash/public/interfaces/container.mojom.h"
+#include "base/memory/ptr_util.h"
#include "services/ui/common/event_matcher_util.h"
#include "services/ui/common/types.h"
#include "services/ui/public/cpp/property_type_converters.h"
@@ -30,39 +32,11 @@
#include "services/ui/public/cpp/window_tree_client.h"
#include "services/ui/public/interfaces/mus_constants.mojom.h"
#include "services/ui/public/interfaces/window_manager.mojom.h"
-#include "ui/app_list/presenter/app_list_presenter.h"
#include "ui/base/hit_test.h"
#include "ui/events/mojo/event.mojom.h"
#include "ui/views/mus/pointer_watcher_event_router.h"
#include "ui/views/mus/screen_mus.h"
-namespace {
-
-// TODO(jamescook): Port ash::sysui::AppListPresenterMus and eliminate this.
-class AppListPresenterStub : public app_list::AppListPresenter {
- public:
- AppListPresenterStub() {}
- ~AppListPresenterStub() override {}
-
- // app_list::AppListPresenter:
- void Show(int64_t display_id) override { NOTIMPLEMENTED(); }
- void Dismiss() override { NOTIMPLEMENTED(); }
- void ToggleAppList(int64_t display_id) override { NOTIMPLEMENTED(); }
- bool IsVisible() const override {
- NOTIMPLEMENTED();
- return false;
- }
- bool GetTargetVisibility() const override {
- NOTIMPLEMENTED();
- return false;
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(AppListPresenterStub);
-};
-
-} // namespace
-
namespace ash {
namespace mus {
@@ -98,10 +72,8 @@ void WindowManager::Init(
window_manager_client_->SetFrameDecorationValues(
std::move(frame_decoration_values));
- std::unique_ptr<ShellDelegate> shell_delegate(new ShellDelegateMus(
- base::MakeUnique<AppListPresenterStub>(), connector_));
- shell_.reset(new WmShellMus(std::move(shell_delegate), this,
- pointer_watcher_event_router_.get()));
+ shell_.reset(new WmShellMus(base::MakeUnique<ShellDelegateMus>(connector_),
+ this, pointer_watcher_event_router_.get()));
shell_->Initialize(blocking_pool);
lookup_.reset(new WmLookupMus);
}
« no previous file with comments | « ash/mus/shell_delegate_mus.cc ('k') | ash/sysui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698