Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm
index 663b3f2283f2e84a3a01dd3085a0485cb8987ac5..cb6e4d2689ae210c291e210f52e9758efdea5123 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm
@@ -15,7 +15,9 @@
#include "ui/base/test/scoped_fake_nswindow_fullscreen.h"
IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, HasLocationBarByDefault) {
- PermissionBubbleCocoa bubble(browser());
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ PermissionBubbleCocoa bubble(web_contents);
bubble.SetDelegate(test_delegate());
bubble.Show(requests(), accept_states());
EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);
@@ -26,7 +28,9 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,
BrowserFullscreenHasLocationBar) {
ui::test::ScopedFakeNSWindowFullscreen faker;
- PermissionBubbleCocoa bubble(browser());
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ PermissionBubbleCocoa bubble(web_contents);
bubble.SetDelegate(test_delegate());
bubble.Show(requests(), accept_states());
EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);
@@ -59,7 +63,9 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,
TabFullscreenHasLocationBar) {
ui::test::ScopedFakeNSWindowFullscreen faker;
- PermissionBubbleCocoa bubble(browser());
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ PermissionBubbleCocoa bubble(web_contents);
bubble.SetDelegate(test_delegate());
bubble.Show(requests(), accept_states());
EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);
@@ -81,7 +87,9 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,
IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, AppHasNoLocationBar) {
Browser* app_browser = OpenExtensionAppWindow();
- PermissionBubbleCocoa bubble(app_browser);
+ content::WebContents* web_contents =
+ app_browser->tab_strip_model()->GetActiveWebContents();
+ PermissionBubbleCocoa bubble(web_contents);
bubble.SetDelegate(test_delegate());
bubble.Show(requests(), accept_states());
EXPECT_FALSE([bubble.bubbleController_ hasVisibleLocationBar]);
@@ -92,7 +100,9 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, AppHasNoLocationBar) {
// Kiosk mode on Mac has a location bar but it shouldn't.
IN_PROC_BROWSER_TEST_F(PermissionBubbleKioskBrowserTest,
DISABLED_KioskHasNoLocationBar) {
- PermissionBubbleCocoa bubble(browser());
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ PermissionBubbleCocoa bubble(web_contents);
bubble.SetDelegate(test_delegate());
bubble.Show(requests(), accept_states());
EXPECT_FALSE([bubble.bubbleController_ hasVisibleLocationBar]);

Powered by Google App Engine
This is Rietveld 408576698